Query Action implementation & related refactoring #20975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20975 +/- ##
=======================================
Coverage 14.59% 14.59%
=======================================
Files 51 51
Lines 1398 1398
Branches 214 214
=======================================
Hits 204 204
Misses 1178 1178
Partials 16 16Continue to review full report at Codecov.
|
gimantha
reviewed
Feb 13, 2020
| selectClause.expression.type = fromClause.varType; | ||
| } | ||
|
|
||
| BLangInvocation lengthInvocation = createLengthInvocation(selectClause.pos, outputArrayVariable.symbol); |
There was a problem hiding this comment.
Shall we replace this with a simple array:push function?
There was a problem hiding this comment.
Facing an issue for primitive arrays @ runtime when using push method. Will attend this separately.
gimantha
reviewed
Feb 13, 2020
...rina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/CodeAnalyzer.java
Outdated
Show resolved
Hide resolved
gimantha
reviewed
Feb 13, 2020
...-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/DataflowAnalyzer.java
Outdated
Show resolved
Hide resolved
mohanvive
changed the title
gimantha
approved these changes
Feb 13, 2020
This was referenced Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #20726
Check List