Allow mapping-constructor-expr to be optional in annotations
#28938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasinicl
requested review from
rdhananjaya,
mohanvive,
gimantha,
grainier and
pcnfernando
grainier
reviewed
Mar 2, 2021
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Outdated
Show resolved
Hide resolved
grainier
previously approved these changes
Mar 2, 2021
|
@lasinicl can you please create an issue to update BBEs with this change |
MaryamZi
reviewed
Mar 3, 2021
.../ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/AnnotationDesugar.java
Show resolved
Hide resolved
...-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java
Outdated
Show resolved
Hide resolved
...-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java
Show resolved
Hide resolved
rdhananjaya
reviewed
Mar 3, 2021
...-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java
Outdated
Show resolved
Hide resolved
MaryamZi
reviewed
Mar 4, 2021
...-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java
Outdated
Show resolved
Hide resolved
MaryamZi
reviewed
Mar 4, 2021
.../ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/AnnotationDesugar.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Outdated
Show resolved
Hide resolved
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Outdated
Show resolved
Hide resolved
|
MaryamZi
reviewed
Mar 5, 2021
| @@ -367,4 +369,89 @@ public void testAnnotsWithConstLists() { | |||
| Assert.assertEquals(element.getKind(), NodeKind.LITERAL); | |||
| Assert.assertEquals(((BLangLiteral) element).value, "test"); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Sorry, missed this previously. But shall we add some runtime tests too? See org.ballerinalang.test.annotations.AnnotationRuntimeTest. The data provider at https://github.com/ballerina-platform/ballerina-lang/blob/master/tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/annotations/AnnotationRuntimeTest.java#L87 doesn't seem to be used though (the test that used that seems to have gotten removed :/), so we'll have to add that back too.
There was a problem hiding this comment.
Basically let's test the following,
- map type
- record type with required fields that have defaults (at runtime we can check if the default was set)
- array of maps or records
Codecov Report
@@ Coverage Diff @@
## master #28938 +/- ##
============================================
+ Coverage 66.36% 66.37% +0.01%
- Complexity 33569 33590 +21
============================================
Files 2747 2747
Lines 149095 149112 +17
Branches 17996 18004 +8
============================================
+ Hits 98943 98977 +34
+ Misses 44249 44237 -12
+ Partials 5903 5898 -5
Continue to review full report at Codecov.
|
MaryamZi
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title.
Fixes #28885
Fixes #27498
Approach
Samples
Remarks
Check List