Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API to type ref symbol to get the associated definition symbol #29626

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

pubudu91
Copy link
Contributor

Purpose

This PR adds a new method to TypeReferenceTypeSymbol to get the definition symbol the type ref is referring to.

Fix #29287
Fix #27804

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@pubudu91 pubudu91 added Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Area/SemanticAPI Semantic API Related Issues #Compiler labels Mar 26, 2021
@pubudu91 pubudu91 added this to the Ballerina Swan Lake - Alpha4 milestone Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #29626 (4e27498) into master (162adbc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29626   +/-   ##
=========================================
  Coverage     67.48%   67.48%           
- Complexity    34870    34876    +6     
=========================================
  Files          2808     2808           
  Lines        152233   152238    +5     
  Branches      18485    18485           
=========================================
+ Hits         102731   102737    +6     
- Misses        43370    43373    +3     
+ Partials       6132     6128    -4     
Impacted Files Coverage Δ Complexity Δ
...impl/symbols/BallerinaTypeReferenceTypeSymbol.java 69.38% <100.00%> (+3.47%) 16.00 <2.00> (+2.00)
...java/io/ballerina/runtime/internal/BLockStore.java 71.42% <0.00%> (-14.29%) 6.00% <0.00%> (-1.00%)
...runtime/internal/scheduling/WorkerDataChannel.java 84.71% <0.00%> (-3.19%) 34.00% <0.00%> (ø%)
.../ballerina/runtime/internal/scheduling/Strand.java 78.33% <0.00%> (-1.12%) 43.00% <0.00%> (-1.00%)
.../compiler/bir/codegen/interop/JMethodResolver.java 78.04% <0.00%> (+0.27%) 184.00% <0.00%> (+1.00%)
...lerinalang/langserver/common/utils/CommonUtil.java 71.96% <0.00%> (+0.46%) 123.00% <0.00%> (+1.00%)
...viders/context/ListenerDeclarationNodeContext.java 74.63% <0.00%> (+0.72%) 36.00% <0.00%> (+1.00%)
...lerinalang/diagramutil/SyntaxTreeMapGenerator.java 63.13% <0.00%> (+0.92%) 41.00% <0.00%> (+1.00%)
...ang/compiler/semantics/model/types/BUnionType.java 71.66% <0.00%> (+1.11%) 63.00% <0.00%> (+1.00%)
...n/java/io/ballerina/projects/bala/BalaProject.java 76.47% <0.00%> (+11.76%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162adbc...4e27498. Read the comment docs.

@pubudu91 pubudu91 merged commit 47f4ca3 into ballerina-platform:master Mar 26, 2021
@pubudu91 pubudu91 deleted the fix-29287 branch March 26, 2021 15:24
@shehan360 shehan360 mentioned this pull request Mar 26, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemanticAPI Semantic API Related Issues #Compiler Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access the Documentation via the TypeSymbol [Semantic API] Type of enums returned as UNION
2 participants