Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run data flow analysis for the then/else expressions of ternary expressions #33608

Merged
merged 2 commits into from Nov 3, 2021

Conversation

MaryamZi
Copy link
Member

@MaryamZi MaryamZi commented Nov 3, 2021

Purpose

$title.

Fixes #33607

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@MaryamZi MaryamZi added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Nov 3, 2021
@MaryamZi MaryamZi added this to the Ballerina Swan Lake - Beta4 milestone Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #33608 (84886d7) into stage-slbeta4 (073b216) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             stage-slbeta4   #33608      +/-   ##
===================================================
- Coverage            71.04%   71.04%   -0.01%     
+ Complexity           43000    42999       -1     
===================================================
  Files                 3120     3120              
  Lines               173971   173973       +2     
  Branches             22423    22423              
===================================================
- Hits                123601   123597       -4     
- Misses               43267    43271       +4     
- Partials              7103     7105       +2     
Impacted Files Coverage Δ
.../compiler/semantics/analyzer/DataflowAnalyzer.java 85.24% <100.00%> (+0.02%) ⬆️
.../ballerina/runtime/internal/scheduling/Strand.java 80.92% <0.00%> (-1.55%) ⬇️
...llerina/runtime/internal/scheduling/Scheduler.java 71.32% <0.00%> (-1.48%) ⬇️
...runtime/internal/scheduling/WorkerDataChannel.java 87.89% <0.00%> (-1.28%) ⬇️
...llerinalang/compiler/util/ImmutableTypeCloner.java 90.10% <0.00%> (-0.54%) ⬇️
.../compiler/bir/codegen/interop/JMethodResolver.java 78.85% <0.00%> (+0.26%) ⬆️
...viders/context/ListenerDeclarationNodeContext.java 74.23% <0.00%> (+0.61%) ⬆️
.../io/ballerina/projects/ModuleCompilationState.java 43.68% <0.00%> (+0.97%) ⬆️
...java/io/ballerina/runtime/internal/BLockStore.java 85.71% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073b216...84886d7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants