Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap working dir path with quotes #34499

Closed
wants to merge 1 commit into from

Conversation

kaviththiranga
Copy link
Contributor

Purpose

This is to prevent invalid arguments being passed into JVM
when the cwd has spaces in its name.

Fixes #34496

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #34499 (0e92070) into stage-swan-lake-rc1 (4b6a53b) will decrease coverage by 3.10%.
The diff coverage is 0.00%.

❗ Current head 0e92070 differs from pull request most recent head b113392. Consider uploading reports for the commit b113392 to get more accurate results
Impacted file tree graph

@@                    Coverage Diff                    @@
##             stage-swan-lake-rc1   #34499      +/-   ##
=========================================================
- Coverage                  74.04%   70.93%   -3.11%     
+ Complexity                 46468    44352    -2116     
=========================================================
  Files                       3180     3166      -14     
  Lines                     181622   179589    -2033     
  Branches                   23382    23148     -234     
=========================================================
- Hits                      134482   127392    -7090     
- Misses                     39241    44982    +5741     
+ Partials                    7899     7215     -684     
Impacted Files Coverage Δ
...rg/ballerinalang/central/client/model/Package.java 26.92% <0.00%> (-0.90%) ⬇️
...gramutil/connector/models/connector/Connector.java 48.00% <ø> (ø)
...rg/ballerinalang/debugadapter/DebugSourceType.java 0.00% <0.00%> (-100.00%) ⬇️
...g/ballerinalang/debugadapter/DebugInstruction.java 0.00% <0.00%> (-100.00%) ⬇️
.../ballerinalang/debugadapter/DebugProjectCache.java 0.00% <0.00%> (-100.00%) ⬇️
.../ballerinalang/debugadapter/EvaluationContext.java 0.00% <0.00%> (-100.00%) ⬇️
...ballerinalang/debugadapter/evaluation/BImport.java 0.00% <0.00%> (-100.00%) ⬇️
...allerinalang/debugadapter/variable/types/BNil.java 0.00% <0.00%> (-100.00%) ⬇️
...llerinalang/debugadapter/utils/SourceResolver.java 0.00% <0.00%> (-100.00%) ⬇️
...llerinalang/debugadapter/variable/types/BJson.java 0.00% <0.00%> (-100.00%) ⬇️
... and 300 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e685a1...b113392. Read the comment docs.

@NipunaMadhushan
Copy link
Contributor

NipunaMadhushan commented Jan 4, 2022

@kaviththiranga I checked the changes in Ubuntu, CentOS and MacOS. Heap dumps are generated without causing any error. #32740 is also the same issue and it works fine in VSCode with the changes in this PR.

@keizer619
Copy link
Member

@NipunaMadhushan @kaviththiranga Shall we send this to stage-swan-lake-rc1 branch as we do release on that branch

@kaviththiranga kaviththiranga changed the base branch from master to stage-swan-lake-rc1 January 5, 2022 04:01
@kaviththiranga
Copy link
Contributor Author

@keizer619 changed the branch

This is to prevent invalid arguments being passed into JVM
when the cwd has spaces in its name.

Fixes: #34496
@kaviththiranga
Copy link
Contributor Author

Closing this as the fix is already sent in another commit.

@kaviththiranga kaviththiranga deleted the kaviththiranga-patch-1 branch January 5, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bal CLI fails when a cmd is invoked from a folder which has spaces in name
3 participants