New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap working dir path with quotes #34499
Conversation
Codecov Report
@@ Coverage Diff @@
## stage-swan-lake-rc1 #34499 +/- ##
=========================================================
- Coverage 74.04% 70.93% -3.11%
+ Complexity 46468 44352 -2116
=========================================================
Files 3180 3166 -14
Lines 181622 179589 -2033
Branches 23382 23148 -234
=========================================================
- Hits 134482 127392 -7090
- Misses 39241 44982 +5741
+ Partials 7899 7215 -684
Continue to review full report at Codecov.
|
@kaviththiranga I checked the changes in Ubuntu, CentOS and MacOS. Heap dumps are generated without causing any error. #32740 is also the same issue and it works fine in VSCode with the changes in this PR. |
@NipunaMadhushan @kaviththiranga Shall we send this to |
@keizer619 changed the branch |
This is to prevent invalid arguments being passed into JVM when the cwd has spaces in its name. Fixes: #34496
0e92070
to
b113392
Compare
Closing this as the fix is already sent in another commit. |
Purpose
This is to prevent invalid arguments being passed into JVM
when the cwd has spaces in its name.
Fixes #34496
Approach
Samples
Remarks
Check List