Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Symbol service gives incomplete types for union type symbols' #40209

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

madushajg
Copy link
Contributor

Purpose

Fixes #40207

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.38 ⚠️

Comparison is base (eb7fa13) 77.53% compared to head (98cb7bf) 77.16%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40209      +/-   ##
============================================
- Coverage     77.53%   77.16%   -0.38%     
+ Complexity    67118    54212   -12906     
============================================
  Files          3497     3340     -157     
  Lines        250324   201581   -48743     
  Branches      38208    25898   -12310     
============================================
- Hits         194085   155542   -38543     
+ Misses        47380    37588    -9792     
+ Partials       8859     8451     -408     
Impacted Files Coverage Δ
...sions/ballerina/symbol/BallerinaSymbolService.java 66.16% <100.00%> (ø)

... and 877 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@madushajg madushajg merged commit d02363d into ballerina-platform:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Symbol service gives incomplete types for union type symbols
2 participants