Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bal tool with changes to class loading and packing jars from directory paths #40567

Merged

Conversation

gayaldassanayake
Copy link
Contributor

Purpose

  • Move the classloading of tool jars to BLauncher.Main instead of the bal bash script. The loading is happening iff it is a tool command.
  • Allow a tool creator to specify dependency jar paths using a gitignore type wild card pattern.

Related to - #40264

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gayaldassanayake gayaldassanayake force-pushed the bal-tool-6.1 branch 3 times, most recently from 7c7c7dc to 07ecfd4 Compare June 8, 2023 06:21
@gayaldassanayake gayaldassanayake marked this pull request as ready for review June 8, 2023 06:23
@gayaldassanayake gayaldassanayake force-pushed the bal-tool-6.1 branch 2 times, most recently from 9fe8ac1 to f719a01 Compare June 12, 2023 08:47
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 79.18% and project coverage change: -0.02 ⚠️

Comparison is base (6fcc1f8) 76.38% compared to head (b5eb657) 76.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40567      +/-   ##
============================================
- Coverage     76.38%   76.37%   -0.02%     
- Complexity    54785    54788       +3     
============================================
  Files          3366     3367       +1     
  Lines        206542   206567      +25     
  Branches      26740    26746       +6     
============================================
- Hits         157774   157771       -3     
- Misses        40075    40105      +30     
+ Partials       8693     8691       -2     
Impacted Files Coverage Δ
.../src/main/java/io/ballerina/cli/cmd/Constants.java 0.00% <ø> (ø)
...ain/java/io/ballerina/cli/task/CreateBalaTask.java 0.00% <0.00%> (ø)
.../io/ballerina/cli/task/RunNativeImageTestTask.java 3.01% <0.00%> (ø)
...ballerinalang/central/client/CentralAPIClient.java 36.80% <0.00%> (-0.46%) ⬇️
.../java/io/ballerina/projects/PackageResolution.java 88.27% <ø> (ø)
.../java/io/ballerina/projects/util/ProjectUtils.java 65.73% <ø> (-0.20%) ⬇️
...mpiler/semantics/analyzer/ConstantTypeChecker.java 43.83% <ø> (ø)
.../compiler/semantics/analyzer/SemanticAnalyzer.java 90.96% <ø> (ø)
...ang/compiler/semantics/model/types/BArrayType.java 100.00% <ø> (ø)
...alang/compiler/semantics/model/types/BMapType.java 100.00% <ø> (ø)
... and 54 more

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gayaldassanayake gayaldassanayake merged commit 9800cb7 into ballerina-platform:master Jun 14, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants