Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help texts and make update 7 bal-tools.toml compatible with update 8 #41241

Merged
merged 5 commits into from
Aug 18, 2023

Conversation

gayaldassanayake
Copy link
Contributor

Purpose

$ subject

Fixes #40264

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

* bal-tools.tomls of updates 6, 7 only has id, name and org fields. Therefore, we need to update the
* bal-tools.toml file when the user moves from updates 6, 7 to update 8 and above.
*/
public static void updateOldBalToolsToml() {
Copy link
Contributor

@azinneera azinneera Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user switches to U8 and switches back to an older update, will the older update break?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. But identified an issue where a user switches from U7->U8->U7->U8 will cause to not have any active version for some tools. Will fix that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with the new commit the changes U7<->U8 are working fine

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 23.91% and project coverage change: -0.01% ⚠️

Comparison is base (e57a4ab) 76.35% compared to head (0a7c088) 76.35%.
Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #41241      +/-   ##
============================================
- Coverage     76.35%   76.35%   -0.01%     
- Complexity    52301    52317      +16     
============================================
  Files          2866     2866              
  Lines        197635   197693      +58     
  Branches      25687    25698      +11     
============================================
+ Hits         150913   150942      +29     
- Misses        38413    38445      +32     
+ Partials       8309     8306       -3     
Files Changed Coverage Δ
.../src/main/java/io/ballerina/cli/launcher/Main.java 0.00% <0.00%> (ø)
...a/io/ballerina/cli/launcher/util/BalToolsUtil.java 0.00% <0.00%> (ø)
...ina/projects/internal/BalToolsManifestBuilder.java 0.00% <0.00%> (ø)
.../java/io/ballerina/projects/util/ProjectUtils.java 62.79% <33.33%> (-0.25%) ⬇️
...o/ballerina/projects/internal/ManifestBuilder.java 76.32% <51.51%> (+1.26%) ⬆️
...va/io/ballerina/projects/JBallerinaBalaWriter.java 85.21% <66.66%> (+0.26%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azinneera azinneera merged commit b257616 into ballerina-platform:master Aug 18, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: Implement bal tool command
2 participants