-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update help texts and make update 7 bal-tools.toml compatible with update 8 #41241
Update help texts and make update 7 bal-tools.toml compatible with update 8 #41241
Conversation
* bal-tools.tomls of updates 6, 7 only has id, name and org fields. Therefore, we need to update the | ||
* bal-tools.toml file when the user moves from updates 6, 7 to update 8 and above. | ||
*/ | ||
public static void updateOldBalToolsToml() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a user switches to U8 and switches back to an older update, will the older update break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. But identified an issue where a user switches from U7->U8->U7->U8 will cause to not have any active version for some tools. Will fix that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now with the new commit the changes U7<->U8 are working fine
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #41241 +/- ##
============================================
- Coverage 76.35% 76.35% -0.01%
- Complexity 52301 52317 +16
============================================
Files 2866 2866
Lines 197635 197693 +58
Branches 25687 25698 +11
============================================
+ Hits 150913 150942 +29
- Misses 38413 38445 +32
+ Partials 8309 8306 -3
☔ View full report in Codecov by Sentry. |
Purpose
$ subject
Fixes #40264
Approach
Samples
Remarks
Check List