Fix BInvokableType record fields of effective types not inheriting readonly flag
#42582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thushara-Piyasekara
force-pushed
the
openhealth-readonly-fix
branch
from
cdfb396
to
a4f21bd
Compare
Thushara-Piyasekara
requested review from
sameerajayasoma and
hasithaa
as code owners
Thushara-Piyasekara
changed the title
BInvokableType fields of effective types not inheriting readonly flagBInvokableType record fields of effective types not inheriting readonly flag
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
Closed PR due to inactivity for more than 18 days. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42582 +/- ##
============================================
- Coverage 77.69% 77.68% -0.02%
+ Complexity 51483 51472 -11
============================================
Files 2933 2933
Lines 204235 204235
Branches 26716 26716
============================================
- Hits 158678 158651 -27
- Misses 36935 36958 +23
- Partials 8622 8626 +4 ☔ View full report in Codecov by Sentry. |
...rd/cloned_record_field_flag_inheritance/imported_module_with_readonly_records/Ballerina.toml
Outdated
Show resolved
Hide resolved
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #42439
Approach
When generating the effective types, the original type is cloned. But during the cloning process the original flags of
BInvokableTypefields ofBRecordTypewere not inherited properly. With this PR we fixed this inheritance issue.Samples
Remarks
Check List