Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port nBallerina readonly and error types #42663

Merged
merged 2 commits into from May 7, 2024
Merged

Port nBallerina readonly and error types #42663

merged 2 commits into from May 7, 2024

Conversation

lochana-chathura
Copy link
Member

@lochana-chathura lochana-chathura commented Apr 30, 2024 •
edited

Purpose

$subject.

Fixes #42652

Approach

n/a

Samples

n/a

Remarks

n/a

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@lochana-chathura lochana-chathura added Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Area/SemtypePort Issues related to porting of semantic subtyping labels Apr 30, 2024
@lochana-chathura lochana-chathura mentioned this pull request May 2, 2024
Merged
13 tasks
@lochana-chathura lochana-chathura mentioned this pull request May 3, 2024
Closed
lochana-chathura
lochana-chathura commented May 3, 2024
View reviewed changes
...lerina-semtype-port-test/src/test/resources/test-src/type-rel/fixed-length-array-large-t.bal
type LargeArray int[MAX_VALUE];

// @type LargeArray2 < IntArray
// -@type LargeArray <> LargeArray2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #42684

heshanpadmasiri
heshanpadmasiri reviewed May 6, 2024
View reviewed changes
Copy link
Member

@heshanpadmasiri heshanpadmasiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits. Other than that LGTM

semtypes/src/main/java/io/ballerina/types/PredefinedType.java Outdated Show resolved Hide resolved
semtypes/src/main/java/io/ballerina/types/Error.java Show resolved Hide resolved
heshanpadmasiri
heshanpadmasiri approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@heshanpadmasiri heshanpadmasiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lochana-chathura lochana-chathura merged commit 3994fe5 into ballerina-platform:nutcracker May 7, 2024
16 checks passed
@lochana-chathura lochana-chathura deleted the semport/error branch May 7, 2024 05:57
@lochana-chathura lochana-chathura mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heshanpadmasiri heshanpadmasiri heshanpadmasiri approved these changes

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

Assignees
No one assigned
Labels
Area/SemtypePort Issues related to porting of semantic subtyping Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lochana-chathura @heshanpadmasiri