-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the getLocation
API for structured type symbols
#42737
Conversation
...a-compiler-api-test/src/test/java/io/ballerina/semantic/api/test/symbols/TypeSymbolTest.java
Outdated
Show resolved
Hide resolved
...a-compiler-api-test/src/test/java/io/ballerina/semantic/api/test/symbols/TypeSymbolTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42737 +/- ##
=========================================
Coverage 77.19% 77.19%
- Complexity 51286 51292 +6
=========================================
Files 2929 2930 +1
Lines 204409 204432 +23
Branches 26665 26669 +4
=========================================
+ Hits 157798 157819 +21
+ Misses 38052 38051 -1
- Partials 8559 8562 +3 ☔ View full report in Codecov by Sentry. |
...a-compiler-api-test/src/test/java/io/ballerina/semantic/api/test/symbols/TypeSymbolTest.java
Outdated
Show resolved
Hide resolved
...a-compiler-api-test/src/test/java/io/ballerina/semantic/api/test/symbols/TypeSymbolTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor level comment
Purpose
$title.
Fixes #42725
Approach
Implemented an abstract class named
StructuredTypeSymbol
that holds the common implementation for such structured type symbols.Check List