Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the getLocation API for structured type symbols #42737

Merged
merged 3 commits into from
May 17, 2024

Conversation

nipunayf
Copy link
Contributor

Purpose

$title.

Fixes #42725

Approach

Implemented an abstract class named StructuredTypeSymbol that holds the common implementation for such structured type symbols.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@nipunayf nipunayf added the Team/LanguageServer Language Server Implementation related issues. #Compiler label May 13, 2024
@nipunayf nipunayf marked this pull request as ready for review May 13, 2024 06:25
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (f10ef24) to head (5eb1822).
Report is 23 commits behind head on master.

❗ Current head 5eb1822 differs from pull request most recent head e3fe019. Consider uploading reports for the commit e3fe019 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #42737   +/-   ##
=========================================
  Coverage     77.19%   77.19%           
- Complexity    51286    51292    +6     
=========================================
  Files          2929     2930    +1     
  Lines        204409   204432   +23     
  Branches      26665    26669    +4     
=========================================
+ Hits         157798   157819   +21     
+ Misses        38052    38051    -1     
- Partials       8559     8562    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dulajdilshan dulajdilshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor level comment

@nipunayf nipunayf merged commit 5ddcc9f into ballerina-platform:master May 17, 2024
16 checks passed
@nipunayf nipunayf added this to the 2201.10.0 milestone May 17, 2024
@nipunayf nipunayf added Team/CompilerFETools Semantic API, Formatter, Shell Area/SemanticAPI Semantic API Related Issues #Compiler and removed Team/LanguageServer Language Server Implementation related issues. #Compiler labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemanticAPI Semantic API Related Issues #Compiler Team/CompilerFETools Semantic API, Formatter, Shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Implement the getLocation API for the structured type symbols
3 participants