Generate unknown type diagnostic for checked explicit constructors #42756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunayf
added
the
Team/LanguageServer
nipunayf
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42756 +/- ##
============================================
- Coverage 77.26% 77.26% -0.01%
Complexity 51301 51301
============================================
Files 2928 2928
Lines 204391 204392 +1
Branches 26659 26660 +1
============================================
- Hits 157925 157921 -4
- Misses 37885 37888 +3
- Partials 8581 8583 +2 ☔ View full report in Codecov by Sentry. |
| @@ -624,7 +624,7 @@ public boolean isNotUnknownTypeRef(BLangUserDefinedType td) { | |||
| Location pos = td.pos; | |||
| LocationData locationData = new LocationData(td.typeName.value, pos.lineRange().startLine().line(), | |||
| pos.lineRange().startLine().offset()); | |||
| return unknownTypeRefs.add(locationData); | |||
| return dlog.isMute() || unknownTypeRefs.add(locationData); | |||
There was a problem hiding this comment.
Will this reflect the function signature?
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title.
Fixes #42705
Approach
The
unknownTypeRefsare updated even during silent type checking, which in result excludes relevant unknown type diagnostics. With the changes, the respective set is only updated if the diagnostic log is not muted.Check List