Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable function pointer byte default value test #42768

Merged

Conversation

gabilang
Copy link
Contributor

@gabilang gabilang commented May 16, 2024

Purpose

$title

Fixes #31680

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gabilang gabilang added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.26%. Comparing base (b8a4619) to head (36f76bb).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #42768      +/-   ##
============================================
+ Coverage     77.20%   77.26%   +0.05%     
- Complexity    51288    51298      +10     
============================================
  Files          2928     2928              
  Lines        204401   204391      -10     
  Branches      26665    26659       -6     
============================================
+ Hits         157806   157917     +111     
+ Misses        38034    37893     -141     
- Partials       8561     8581      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit a52b520 into ballerina-platform:master May 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable test on function pointer with defaultable parameter: functions_with_default_parameters.bal
2 participants