Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the search space for listInhabited with large number of negative atoms #42774

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Reduce the search space for listInhabited with large number of negative atoms #42774

merged 4 commits into from
Jun 5, 2024

Conversation

heshanpadmasiri
Copy link
Member

@heshanpadmasiri heshanpadmasiri commented May 19, 2024 •
edited

Purpose

$subject

Fixes #42773

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@heshanpadmasiri heshanpadmasiri marked this pull request as draft May 20, 2024 03:09
@heshanpadmasiri heshanpadmasiri marked this pull request as ready for review May 21, 2024 06:56
lochana-chathura
lochana-chathura approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@lochana-chathura lochana-chathura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...rina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/model/types/BJSONType.java Outdated Show resolved Hide resolved
@heshanpadmasiri @lochana-chathura
Fix typo in comment
8ca8ca7 
Co-authored-by: lochana-chathura <39232462+lochana-chathura@users.noreply.github.com>
@lochana-chathura lochana-chathura merged commit 7fbabfe into ballerina-platform:nutcracker Jun 5, 2024
14 of 16 checks passed
@lochana-chathura lochana-chathura mentioned this pull request Jun 5, 2024
Closed
@heshanpadmasiri heshanpadmasiri deleted the fix/list-long-neg-list branch June 5, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lochana-chathura lochana-chathura lochana-chathura approved these changes

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heshanpadmasiri @lochana-chathura