-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExternalDependency annotation #42792
Merged
hasithaa
merged 7 commits into
ballerina-platform:master
from
Thushara-Piyasekara:externalDependencyAnnotation
Jun 10, 2024
Merged
Add ExternalDependency annotation #42792
hasithaa
merged 7 commits into
ballerina-platform:master
from
Thushara-Piyasekara:externalDependencyAnnotation
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ina-lang into externalDependencyAnnotation
…shara-Piyasekara/ballerina-lang into externalDependencyAnnotation
…ina-lang into externalDependencyAnnotation
This reverts commit 580181f.
Thushara-Piyasekara
requested review from
sameerajayasoma and
hasithaa
as code owners
May 22, 2024 04:37
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42792 +/- ##
=========================================
Coverage 77.28% 77.29%
- Complexity 51339 51350 +11
=========================================
Files 2929 2932 +3
Lines 204465 204510 +45
Branches 26683 26691 +8
=========================================
+ Hits 158030 158083 +53
+ Misses 37846 37837 -9
- Partials 8589 8590 +1 ☔ View full report in Codecov by Sentry. |
13 tasks
…ina-lang into externalDependencyAnnotation
prakanth97
reviewed
Jun 7, 2024
prakanth97
reviewed
Jun 7, 2024
...nit-test/src/test/resources/test-src/annotations/external_dependency_annotation_negative.bal
Outdated
Show resolved
Hide resolved
prakanth97
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hasithaa
approved these changes
Jun 10, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
With this PR, a new annotation is introduced to annotate ballerina type definitions which are accessed through external Java dependencies.
Fixes #42205
Approach
This new annotation was added to jballerina.java lang library. It can be accessed by importing jballerina.java in any ballerina module.
Samples
Remarks
Check List