Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExternalDependency annotation #42792

Conversation

Thushara-Piyasekara
Copy link
Contributor

Purpose

$subject
With this PR, a new annotation is introduced to annotate ballerina type definitions which are accessed through external Java dependencies.

Fixes #42205

Approach

This new annotation was added to jballerina.java lang library. It can be accessed by importing jballerina.java in any ballerina module.

Samples

import ballerina/jballerina.java;

@java:ExternalDependency
function foo(int x) returns int {
    return x * 2;
}

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.29%. Comparing base (8bbaeaa) to head (6d3dd2d).
Report is 66 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #42792   +/-   ##
=========================================
  Coverage     77.28%   77.29%           
- Complexity    51339    51350   +11     
=========================================
  Files          2929     2932    +3     
  Lines        204465   204510   +45     
  Branches      26683    26691    +8     
=========================================
+ Hits         158030   158083   +53     
+ Misses        37846    37837    -9     
- Partials       8589     8590    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@prakanth97 prakanth97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hasithaa hasithaa merged commit 3ed3075 into ballerina-platform:master Jun 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: Add annotation for ballerina constructs called through io.ballerina.runtime.api.creators API
3 participants