Fix bad sad error in SemanticAnalyzer

[mindula]

Purpose

$title.

Fixes #41101

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.26%. Comparing base (0849031) to head (94f32c2).
Report is 148 commits behind head on master.

Files	Patch %	Lines
.../compiler/semantics/analyzer/SemanticAnalyzer.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #42796   +/-   ##
=========================================
  Coverage     77.26%   77.26%           
- Complexity    51302    51303    +1     
=========================================
  Files          2929     2929           
  Lines        204423   204423           
  Branches      26668    26668           
=========================================
+ Hits         157938   157940    +2     
+ Misses        37896    37894    -2     
  Partials       8589     8589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chiranSachintha]

If the variable is in the package scope, we define those variables in the symbol enter. Here, what we define are variables within functions, and the variables' owner becomes let. In the following scenario, the owner tag should also be equal to let.

In the current implementation, we set the owner as package instead of let. This is the root cause of the issue.

type Student record {|
    string fname;
    string lname;
    int id;
|};

Student[] students = [];

var v1 = from var st in students
    let var name = st.fname + st.lname
    select name;

function testModuleLevelLetClause() {
    var v2 = from var st in students
        let var name = st.fname + st.lname
        select name;
}

[chiranSachintha]

@mindula It's better to change the title to reflect the specific issue we are fixing. As we tag these issues in the release notes, this will provide better understanding to users when they check for changes in the new update.

[github-actions]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.