Fix getting non-accessible symbol error for error intersections with details

[dulajdilshan]

Purpose

$title

Fixes #42806

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.68%. Comparing base (cd5bd3b) to head (6eed512).
Report is 113 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #42876      +/-   ##
============================================
+ Coverage     77.31%   77.68%   +0.36%     
- Complexity    51370    51479     +109     
============================================
  Files          2933     2933              
  Lines        204534   204243     -291     
  Branches      26717    26721       +4     
============================================
+ Hits         158134   158658     +524     
+ Misses        37804    36959     -845     
- Partials       8596     8626      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MaryamZi]

I'd just directly assert the code without going through a mapping.

[dulajdilshan]

But we have to cast it right? Which way is better?

[MaryamZi]

Cast is okay here.

[dulajdilshan]

Do you mean something like this?

if code != () {
    record {|int code;|} detail = (<error<record {|int code;|}>>actual).detail();
    if code != detail.code {
        panic error("expected code: '"
                + code.toString() + "' found: '"
                + detail.code.toString() + "'");
    }
}

Wouldn't it be a longer casting and we may need to have another variable for more readability?

[MaryamZi]

You can do record {|int code;|} detail = <record {|int code;|} & readonly> actual.detail(); or var on LHS.

Can also use a string template to avoid toString.

[dulajdilshan]

Updated in 99cd23a