Introduce transactionAutoCommitTimeout and transactionCleanupTimeout configuration values for transactions

[dsplayerX]

Purpose

Introduces new configurations to prevent premature commits of long-running transactions before reaching the commit phase.

Related #42922

Approach

This PR introduces two new configurations values for transactions, transactionAutoCommitTimeout and transactionCleanupTimeout.

ballerinai-transaction PR: ballerina-platform/module-ballerinai-transaction#549

Samples

You can change the Config.toml with these two new configs as below.

[ballerina.lang.transaction]
transactionAutoCommitTimeout=120
transactionCleanupTimeout=600

Remarks

ballerinai-transaction PR: ballerina-platform/module-ballerinai-transaction#549

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 77.29%. Comparing base (02e0001) to head (a6332d8).
Report is 157 commits behind head on master.

❗ Current head a6332d8 differs from pull request most recent head 7e1c5e4

Please upload reports for the commit 7e1c5e4 to get more accurate results.

Files	Patch %	Lines
...ntime/transactions/TransactionResourceManager.java	0.00%	16 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #42940      +/-   ##
============================================
- Coverage     77.29%   77.29%   -0.01%     
- Complexity    51350    51357       +7     
============================================
  Files          2932     2932              
  Lines        204512   204545      +33     
  Branches      26692    26716      +24     
============================================
+ Hits         158084   158103      +19     
- Misses        37838    37846       +8     
- Partials       8590     8596       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chiranSachintha]

Shall we add test for this change.

[ThisaruGuruge]

Can we do this fix for 8.x as well?

[dsplayerX]

Shall we add test for this change.

@chiranSachintha Could you suggest a way to add test cases please?

[chiranSachintha]

@chiranSachintha Could you suggest a way to add test cases please?

You can write an external function for the getTransactionAutoCommitTimeout function from the Ballerina side and then test it by sending values as a configurable variable. You can check the test cases here.

[chiranSachintha]

Suggested change

	private static int parseTimeoutValue(Object value, int defaultValue) {
	if (!(value instanceof Number number)) {
	return defaultValue;
	}
	int timeoutValue = number.intValue();
	if (timeoutValue <= 0) {
	return defaultValue;
	}
	return timeoutValue;
	}
	private static int parseTimeoutValue(Object value, int defaultValue) {
	if (value instanceof Number number) {
	int timeoutValue = number.intValue();
	if (timeoutValue > 0) {
	return timeoutValue;
	}
	}
	return defaultValue;
	}

[dsplayerX]

IMO, I think returning the parsed value at the bottom of the method makes it clear that the method’s primary purpose is to return a valid timeout value if possible, and only return the default value if the parsing or validation fails.

[chiranSachintha]

The advantage of this refactoring is this reduces the number of return statements and keeps the code concise.