Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.9.x] Introduce transactionAutoCommitTimeout and transactionCleanupTimeout configuration values for transactions #42963

Open
wants to merge 9 commits into
base: 2201.9.x
Choose a base branch
from

Conversation

dsplayerX
Copy link
Contributor

Purpose

Introduces new configurations to prevent premature commits of long-running transactions before reaching the commit phase.

Related #42922

Approach

This PR introduces two new configurations values for transactions, transactionAutoCommitTimeout and transactionCleanupTimeout.

ballerinai-transaction PR: ballerina-platform/module-ballerinai-transaction#549

Samples

You can change the Config.toml with these two new configs as below.

[ballerina.lang.transaction]
transactionAutoCommitTimeout=120
transactionCleanupTimeout=600

Remarks

ballerinai-transaction PR: ballerina-platform/module-ballerinai-transaction#549

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 76.86%. Comparing base (7d1f3ca) to head (6e22127).
Report is 30 commits behind head on 2201.9.x.

Current head 6e22127 differs from pull request most recent head f5cc07d

Please upload reports for the commit f5cc07d to get more accurate results.

Files Patch % Lines
...ntime/transactions/TransactionResourceManager.java 0.00% 20 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             2201.9.x   #42963      +/-   ##
==============================================
- Coverage       76.87%   76.86%   -0.02%     
- Complexity      54083    54118      +35     
==============================================
  Files            2925     2925              
  Lines          204270   204397     +127     
  Branches        26660    26687      +27     
==============================================
+ Hits           157039   157108      +69     
- Misses          38660    38717      +57     
- Partials         8571     8572       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsplayerX dsplayerX force-pushed the fix_42922_long_running_trans_9.x branch from 6e22127 to f5cc07d Compare June 21, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant