Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review suggestions of #42950 #42964

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Address review suggestions of #42950 #42964

merged 1 commit into from
Jun 21, 2024

Conversation

dsplayerX
Copy link
Contributor

@dsplayerX dsplayerX commented Jun 21, 2024 •
edited
Loading

Purpose

Address minor review suggestions of merged PR: #42950

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@dsplayerX dsplayerX changed the title Address review suggestions of https://github.com/ballerina-platform/ballerina-lang/pull/42950 Address review suggestions of #42950 Jun 21, 2024
@dsplayerX dsplayerX added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Jun 21, 2024
@dsplayerX dsplayerX mentioned this pull request Jun 21, 2024
Merged
13 tasks
@chiranSachintha chiranSachintha merged commit fa2e27f into ballerina-platform:2201.8.7-stage Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiranSachintha chiranSachintha chiranSachintha approved these changes

@warunalakshitha warunalakshitha Awaiting requested review from warunalakshitha warunalakshitha is a code owner

Assignees
No one assigned
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsplayerX @chiranSachintha