-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port object semtype to jBallerina #42975
base: nutcracker
Are you sure you want to change the base?
Port object semtype to jBallerina #42975
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nutcracker #42975 +/- ##
=============================================
Coverage 77.45% 77.46%
+ Complexity 52328 52324 -4
=============================================
Files 2988 2986 -2
Lines 207516 207525 +9
Branches 27167 27169 +2
=============================================
+ Hits 160737 160762 +25
+ Misses 37960 37956 -4
+ Partials 8819 8807 -12 ☔ View full report in Codecov by Sentry. |
new String[]{}, new CellSemType[]{}, CELL_SEMTYPE_OBJECT_MEMBER | ||
); | ||
public static final TypeAtom ATOM_MAPPING_OBJECT = createTypeAtom(8, MAPPING_ATOMIC_OBJECT); | ||
public static final BddNode MAPPING_SUBTYPE_OBJECT = bddAtom(ATOM_MAPPING_OBJECT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can include the comment from nBallerina code as well.
public static final BddNode MAPPING_SUBTYPE_OBJECT = bddAtom(ATOM_MAPPING_OBJECT); | |
// represents record { ObjectField...; } where ObjectField = { string kind; any value } | |
public static final BddNode MAPPING_SUBTYPE_OBJECT = bddAtom(ATOM_MAPPING_OBJECT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment to ObjectDefinition
semtypes/src/main/java/io/ballerina/types/definition/Member.java
Outdated
Show resolved
Hide resolved
semtypes/src/main/java/io/ballerina/types/definition/ObjectDefinition.java
Outdated
Show resolved
Hide resolved
semtypes/src/main/java/io/ballerina/types/definition/ObjectDefinition.java
Outdated
Show resolved
Hide resolved
semtypes/src/main/java/io/ballerina/types/definition/ObjectDefinition.java
Outdated
Show resolved
Hide resolved
semtypes/src/main/java/io/ballerina/types/definition/ObjectDefinition.java
Outdated
Show resolved
Hide resolved
semtypes/src/main/java/io/ballerina/types/definition/ObjectQualifiers.java
Outdated
Show resolved
Hide resolved
semtypes/src/main/java/io/ballerina/types/definition/ObjectQualifiers.java
Outdated
Show resolved
Hide resolved
5b6f01f
to
6cf5a67
Compare
67d92bb
to
76692ce
Compare
76692ce
to
aaf646f
Compare
Purpose
$subject
Fixes #42972
Approach
Samples
Remarks
Check List