Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port object semtype to jBallerina #42975

Open
wants to merge 4 commits into
base: nutcracker
Choose a base branch
from

Conversation

heshanpadmasiri
Copy link
Member

@heshanpadmasiri heshanpadmasiri commented Jun 25, 2024

Purpose

$subject

Fixes #42972

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 95.87629% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (72f1bd8) to head (1bcd46b).
Report is 1 commits behind head on nutcracker.

Current head 1bcd46b differs from pull request most recent head 82d369c

Please upload reports for the commit 82d369c to get more accurate results.

Files Patch % Lines
...ain/java/io/ballerina/types/typeops/ObjectOps.java 71.42% 2 Missing ⚠️
...ain/java/io/ballerina/types/definition/Member.java 95.65% 0 Missing and 1 partial ⚠️
...o/ballerina/types/definition/ObjectDefinition.java 96.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             nutcracker   #42975   +/-   ##
=============================================
  Coverage         77.45%   77.46%           
+ Complexity        52328    52324    -4     
=============================================
  Files              2988     2986    -2     
  Lines            207516   207525    +9     
  Branches          27167    27169    +2     
=============================================
+ Hits             160737   160762   +25     
+ Misses            37960    37956    -4     
+ Partials           8819     8807   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

new String[]{}, new CellSemType[]{}, CELL_SEMTYPE_OBJECT_MEMBER
);
public static final TypeAtom ATOM_MAPPING_OBJECT = createTypeAtom(8, MAPPING_ATOMIC_OBJECT);
public static final BddNode MAPPING_SUBTYPE_OBJECT = bddAtom(ATOM_MAPPING_OBJECT);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can include the comment from nBallerina code as well.

Suggested change
public static final BddNode MAPPING_SUBTYPE_OBJECT = bddAtom(ATOM_MAPPING_OBJECT);
// represents record { ObjectField...; } where ObjectField = { string kind; any value }
public static final BddNode MAPPING_SUBTYPE_OBJECT = bddAtom(ATOM_MAPPING_OBJECT);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment to ObjectDefinition

@lochana-chathura lochana-chathura added Area/SemtypeIntegration Issue related to integrating semtype engine Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. labels Jun 28, 2024
@lochana-chathura lochana-chathura added Area/SemtypePort Issues related to porting of semantic subtyping and removed Area/SemtypeIntegration Issue related to integrating semtype engine labels Jun 28, 2024
@heshanpadmasiri heshanpadmasiri force-pushed the feat/port-object branch 4 times, most recently from 5b6f01f to 6cf5a67 Compare July 3, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemtypePort Issues related to porting of semantic subtyping Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants