Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convert to configurable code action #42983

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LakshanWeerasinghe
Copy link
Contributor

@LakshanWeerasinghe LakshanWeerasinghe commented Jun 25, 2024

Purpose

$subject

Fixes #41345

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Screen.Recording.2024-06-25.at.16.56.37.mov

Remarks

This code action is not working when the type of the variable is anydata. I have add that test case and commented out it.

anydata data = "valu<CURSOR>e"

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@LakshanWeerasinghe LakshanWeerasinghe added Team/LanguageServer Language Server Implementation related issues. #Compiler Area/CodeAction Language Server Code Actions labels Jun 25, 2024
@LakshanWeerasinghe LakshanWeerasinghe added this to the 2201.10.0 milestone Jun 25, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 84.26966% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.34%. Comparing base (1a84008) to head (9593853).
Report is 6 commits behind head on master.

Files Patch % Lines
...ion/providers/ConvertToConfigurableCodeAction.java 84.26% 3 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #42983   +/-   ##
=========================================
  Coverage     77.34%   77.34%           
- Complexity    58233    58273   +40     
=========================================
  Files          3450     3451    +1     
  Lines        218919   219015   +96     
  Branches      28726    28752   +26     
=========================================
+ Hits         169315   169394   +79     
- Misses        40281    40288    +7     
- Partials       9323     9333   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/CodeAction Language Server Code Actions Team/LanguageServer Language Server Implementation related issues. #Compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: Convert to configurable code action
2 participants