Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for brotli compression format #2006

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

Add support for brotli compression format #2006

wants to merge 31 commits into from

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented May 17, 2024 •
edited
Loading

Purpose

$Subject

Fixes: ballerina-platform/ballerina-library#6547

Examples

See the issue for more details

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation

TharmiganK and others added 11 commits May 17, 2024 09:46
@TharmiganK
Add brotli compression support
c6c8111
@TharmiganK
Fix compression test case
3be5f57
@TharmiganK
[Automated] Update the native jar versions
89915a8
@TharmiganK
[Automated] Update the native jar versions
30a4e1a
@TharmiganK
Update changelog
da6e6ed
@TharmiganK
Add native image configurations
5ee556b
@TharmiganK
Merge remote-tracking branch 'refs/remotes/origin/master' into br-enc…
de6d132 
…oding-format

# Conflicts:
#	ballerina-tests/http-advanced-tests/Ballerina.toml
#	ballerina-tests/http-client-tests/Ballerina.toml
#	ballerina-tests/http-dispatching-tests/Ballerina.toml
#	ballerina-tests/http-interceptor-tests/Ballerina.toml
#	ballerina-tests/http-misc-tests/Ballerina.toml
#	ballerina-tests/http-resiliency-tests/Ballerina.toml
#	ballerina-tests/http-security-tests/Ballerina.toml
#	ballerina-tests/http-service-tests/Ballerina.toml
#	ballerina-tests/http2-tests/Ballerina.toml
#	ballerina/Ballerina.toml
#	ballerina/CompilerPlugin.toml
#	changelog.md
@TharmiganK
Merge branch 'master' into br-encoding-format
8eb0422
@TharmiganK
Merge branch 'master' into br-encoding-format
a2040c7
@TharmiganK
Merge branch 'master' into br-encoding-format
fc32ad1
@TharmiganK
Merge branch 'master' into br-encoding-format
a06d2b2
@github-actions github-actions bot added the Stale label Jul 2, 2024
@TharmiganK TharmiganK removed the Stale label Jul 3, 2024
@ballerina-platform ballerina-platform deleted a comment from github-actions bot Aug 15, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.17%. Comparing base (4326c5a) to head (7341bd7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...nsport/contractimpl/Http2OutboundRespListener.java 43.75% 4 Missing and 5 partials ⚠️
...ner/http2/Http2SourceConnectionHandlerBuilder.java 57.14% 2 Missing and 1 partial ⚠️
...ttp/transport/message/HttpMessageDataStreamer.java 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2006      +/-   ##
============================================
- Coverage     80.20%   80.17%   -0.03%     
  Complexity      669      669              
============================================
  Files           408      408              
  Lines         22926    22946      +20     
  Branches       5271     5277       +6     
============================================
+ Hits          18387    18398      +11     
- Misses         3405     3410       +5     
- Partials       1134     1138       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK marked this pull request as ready for review August 21, 2024 09:21
@TharmiganK
Copy link
Contributor Author

This PR is on hold, since this new feature should be added to Update 11

@NipunaRanasinghe
Copy link
Contributor

This PR is on hold, since this new feature should be added to Update 11

@TharmiganK if this is deprioratized, better to close it ftm and we can reopen once we resume the work IMO

@TharmiganK
Copy link
Contributor Author

@TharmiganK if this is deprioratized, better to close it ftm and we can reopen once we resume the work IMO

No, we will merge this for Update 11. I will make this draft since I need to do some testing.

@TharmiganK TharmiganK marked this pull request as draft September 13, 2024 08:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

@lnash94 lnash94 Awaiting requested review from lnash94 lnash94 is a code owner

@daneshk daneshk Awaiting requested review from daneshk daneshk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HTTP compression support for brotli format
2 participants
@TharmiganK @NipunaRanasinghe