Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic deletion for unused dependencies with distribution removal #336

Merged
merged 10 commits into from
Jan 5, 2024

Conversation

udda1996
Copy link
Contributor

Purpose

$title

Goals

fixes #333

Comment on lines 150 to 151
// String activeDistribution = ToolUtil.getCurrentBallerinaVersion();
// String dependencyForActiveDistribution = ToolUtil.getDependency(activeDistribution);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// String activeDistribution = ToolUtil.getCurrentBallerinaVersion();
// String dependencyForActiveDistribution = ToolUtil.getDependency(activeDistribution);

keizer619
keizer619 previously approved these changes Dec 20, 2023
@udda1996 udda1996 dismissed keizer619’s stale review December 20, 2023 04:31

The merge-base changed after approval.

keizer619
keizer619 previously approved these changes Dec 20, 2023
@udda1996 udda1996 dismissed keizer619’s stale review December 20, 2023 04:59

The merge-base changed after approval.

keizer619
keizer619 previously approved these changes Jan 1, 2024
@udda1996 udda1996 dismissed keizer619’s stale review January 1, 2024 04:55

The merge-base changed after approval.

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@udda1996 udda1996 merged commit d3b5e30 into ballerina-platform:master Jan 5, 2024
5 checks passed
@udda1996 udda1996 added this to the 1.4.3 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dependency delete feature once all the distributions under a given dependency got deleted
2 participants