Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the byte support feature into the specification #17

Merged
merged 6 commits into from
May 13, 2024

Conversation

Nuvindu
Copy link
Contributor

@Nuvindu Nuvindu commented May 13, 2024

Purpose

$subject

Comment on lines 85 to 86
| int,long | int | 1 |
| float,double | float | 1.1 |
Copy link
Member

@ThisaruGuruge ThisaruGuruge May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to explain why we use int and float in Ballerina for long and double types. (Maybe we can point the ballerina spec or just describe the ballerina types here).

| enum | enum | enum Color { RED, GREEN, BLUE } |
| array | array | [1,2,3,4,5] |
| map | map | {"a": 1} |
| fixed | byte[] | "000FFFF".toBytes() |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the value addition from the Examples column.

@ThisaruGuruge ThisaruGuruge added the Skip GraalVM Check This will skip the GraalVM compatibility check label May 13, 2024
@Nuvindu Nuvindu merged commit 1913304 into ballerina-platform:main May 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip GraalVM Check This will skip the GraalVM compatibility check
Projects
None yet
2 participants