Address review changes

ballerina-platform · Jan 18, 2024 · d88fbcd · d88fbcd
1 parent 7bcc3f7
commit d88fbcd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/ballerina/segment_group_reader.bal b/ballerina/segment_group_reader.bal
@@ -30,9 +30,7 @@ isolated function readSegmentGroup(EdiUnitSchema[] currentUnitSchema, EdiContext
         if segSchema is () {
             return error Error("Segment schema cannot be empty.");
         }
-        string sDesc = context.ediText[context.rawIndex];
-        string:RegExp newline = re `\n`;
-        string segmentDesc = newline.replaceAll(sDesc, "");
+        string segmentDesc = removeLineBreaks(context.ediText[context.rawIndex]);
         // There can be segments that do not follow standard EDI format (e.g. EDIFACT UNA segment).
         // Therefore, it is necessary to check and skip ignore segments before spliting into fields.
         boolean ignoreCurrentSegment = false;

diff --git a/ballerina/utils.bal b/ballerina/utils.bal
@@ -136,9 +136,8 @@ isolated function splitSegments(string text, string delimiter) returns string[]|
     if segmentLines[segmentLines.length() - 1] == "" {
         string _ = segmentLines.remove(segmentLines.length() - 1);
     }
-    string:RegExp newline = re `\n`;
     foreach int i in 0 ... (segmentLines.length() - 1) {
-        segmentLines[i] = newline.replaceAll(segmentLines[i], "");
+        segmentLines[i] = removeLineBreaks(segmentLines[i]);
     }
     return segmentLines;
 }
@@ -261,3 +260,7 @@ isolated function addPadding(string value, int requiredLength) returns string {
     return paddedValue;
 }
 
+isolated function removeLineBreaks(string value) returns string {
+    string:RegExp newline = re `\n`;
+    return newline.replaceAll(value, "");
+}