Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Email Body retrieval logic in IMAP Listener #468

Merged
merged 17 commits into from
Mar 22, 2022

Conversation

ayeshLK
Copy link
Member

@ayeshLK ayeshLK commented Mar 16, 2022

Purpose

$subject

Fixes #2777

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec

@ayeshLK ayeshLK requested review from chamil321 and removed request for Maninda March 16, 2022 07:03
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #468 (e7e3298) into 2201.0.x (bfaf797) will decrease coverage by 0.08%.
The diff coverage is 76.47%.

@@              Coverage Diff               @@
##             2201.0.x     #468      +/-   ##
==============================================
- Coverage       80.97%   80.88%   -0.09%     
- Complexity        159      160       +1     
==============================================
  Files              22       22              
  Lines            1051     1062      +11     
  Branches          205      207       +2     
==============================================
+ Hits              851      859       +8     
- Misses            115      117       +2     
- Partials           85       86       +1     
Impacted Files Coverage Δ
...o/ballerina/stdlib/email/util/EmailAccessUtil.java 77.89% <76.47%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4b0b6...e7e3298. Read the comment docs.

@shafreenAnfar
Copy link
Contributor

@ayeshLK and I had a chat and decided to update the testcase names. The fix is simply about making MIME type case insensitive. The testcases are simply there to validate this.

Co-authored-by: Chamil Elladeniya <chamilmadawa8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants