Implement AccessLog support for Ballerina #1969
Conversation
AzeemMuzammil
requested review from
shafreenAnfar and
TharmiganK
as code owners
| @@ -144,6 +145,9 @@ public synchronized void addHttpContent(HttpContent httpContent) { | |||
| public HttpContent getHttpContent() { | |||
| HttpContent httpContent = this.blockingEntityCollector.getHttpContent(); | |||
| this.contentObservable.notifyGetListener(httpContent); | |||
| if (httpContent != null) { | |||
There was a problem hiding this comment.
blockingEntityCollector can contain multiple http contents right? In this case we only consider 1 content and set it to the carbon msg. Is that correct?
| @@ -53,6 +59,7 @@ public class ReceivingEntityBody implements SenderState { | |||
| private final Http2TargetHandler http2TargetHandler; | |||
| private final Http2ClientChannel http2ClientChannel; | |||
| private final Http2TargetHandler.Http2RequestWriter http2RequestWriter; | |||
| private Long contentLength = 0L; | |||
There was a problem hiding this comment.
im not sure about storing the content length in the state itself. while receiving the entity body, there is a possibility for the state to change right? if it changes, when receiving the response body again, a new ReceivingEntityBody state will be created that doesn't have the previous contentLength value. This is a possibility right? @TharmiganK
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
AzeemMuzammil
force-pushed
the
fb-access-log-improvement
branch
from
cf289ec
to
a8d6a34
Compare
|
Purpose
$title. please refer to the below proposal.
ballerina-platform/ballerina-library#6111
Examples
Checklist