-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce DefaultStatusCodeResponse
#2002
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2002 +/- ##
============================================
+ Coverage 80.57% 80.96% +0.38%
- Complexity 0 562 +562
============================================
Files 353 390 +37
Lines 19869 21677 +1808
Branches 4633 5003 +370
============================================
+ Hits 16010 17550 +1540
- Misses 2986 3118 +132
- Partials 873 1009 +136 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a minor comment. LGTM
Co-authored-by: Dilan Sachintha Nayanajith <dilansachinthanos@gmail.com>
Please retry analysis of this Pull-Request directly on SonarCloud |
native/src/main/java/io/ballerina/stdlib/http/api/nativeimpl/StatusCodeBindingException.java
Outdated
Show resolved
Hide resolved
…t-status-res # Conflicts: # ballerina-tests/http-advanced-tests/Ballerina.toml # ballerina-tests/http-client-tests/Ballerina.toml # ballerina-tests/http-dispatching-tests/Ballerina.toml # ballerina-tests/http-interceptor-tests/Ballerina.toml # ballerina-tests/http-misc-tests/Ballerina.toml # ballerina-tests/http-resiliency-tests/Ballerina.toml # ballerina-tests/http-security-tests/Ballerina.toml # ballerina-tests/http-service-tests/Ballerina.toml # ballerina-tests/http2-tests/Ballerina.toml # ballerina/Ballerina.toml # ballerina/CompilerPlugin.toml # changelog.md
Quality Gate passedIssues Measures |
Purpose
Fixes: ballerina-platform/ballerina-library#6491
Examples
Client side:
Service side:
Checklist
Updated the spec- will be addressed via Update HTTP spec with the status code response binding in the client side ballerina-library#6289