Merge pull request #40 from vil02/4919_make_some_java_classes_proper_…

…utilities Make some Java classes proper utilities
ballerina-platform · Oct 13, 2023 · 65dd908 · 65dd908
2 parents 295f090 + 1381636
commit 65dd908
Show file tree

Hide file tree

Showing 9 changed files with 25 additions and 8 deletions.
diff --git a/changelog.md b/changelog.md
@@ -10,6 +10,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - [Added support for native image builds](https://github.com/ballerina-platform/ballerina-standard-library/issues/4686)
 - [Added support for request/response pattern](https://github.com/ballerina-platform/ballerina-standard-library/issues/4668)
 
+### Changed
+- [Make some of the Java classes proper utility classes](https://github.com/ballerina-platform/ballerina-standard-library/issues/4919)
+
 ## [0.0.1] - 2023-07-24
 ### Added
 - [Introduce ballerina `mqtt` package](https://github.com/ballerina-platform/ballerina-standard-library/issues/4640)
diff --git a/...plugin-tests/src/test/java/io/ballerina/stdlib/mqtt/compiler/CompilerPluginTestUtils.java b/...plugin-tests/src/test/java/io/ballerina/stdlib/mqtt/compiler/CompilerPluginTestUtils.java
@@ -30,7 +30,9 @@
 /**
  * A class containing the utilities related for compiler plugin tests.
  */
-public class CompilerPluginTestUtils {
+public final class CompilerPluginTestUtils {
+
+    private CompilerPluginTestUtils() {}
 
     public static final Path RESOURCE_DIRECTORY = Paths.get("src", "test", "resources").toAbsolutePath();
     public static final Path DISTRIBUTION_PATH = Paths.get("../", "target", "ballerina-runtime")

diff --git a/compiler-plugin/src/main/java/io/ballerina/stdlib/mqtt/compiler/PluginUtils.java b/compiler-plugin/src/main/java/io/ballerina/stdlib/mqtt/compiler/PluginUtils.java
@@ -42,7 +42,9 @@
 /**
  * Util class for the compiler plugin.
  */
-public class PluginUtils {
+public final class PluginUtils {
+
+    private PluginUtils() {}
 
     public static Diagnostic getDiagnostic(PluginConstants.CompilationErrors error, DiagnosticSeverity severity,
                                            Location location) {

diff --git a/native/src/main/java/io/ballerina/stdlib/mqtt/caller/CallerActions.java b/native/src/main/java/io/ballerina/stdlib/mqtt/caller/CallerActions.java
@@ -37,7 +37,9 @@
 /**
  * Class containing the external methods of the caller.
  */
-public class CallerActions {
+public final class CallerActions {
+
+    private CallerActions() {}
 
     private static final ExecutorService executorService = Executors.newCachedThreadPool(new CallerThreadFactory());
 

diff --git a/native/src/main/java/io/ballerina/stdlib/mqtt/client/ClientActions.java b/native/src/main/java/io/ballerina/stdlib/mqtt/client/ClientActions.java
@@ -59,7 +59,9 @@
 /**
  * Class containing the external methods of the publisher.
  */
-public class ClientActions {
+public final class ClientActions {
+
+    private ClientActions() {}
 
     private static final ExecutorService publishExecutorService =
             Executors.newCachedThreadPool(new ClientThreadFactory());

diff --git a/native/src/main/java/io/ballerina/stdlib/mqtt/listener/ListenerActions.java b/native/src/main/java/io/ballerina/stdlib/mqtt/listener/ListenerActions.java
@@ -36,7 +36,9 @@
 /**
  * Class containing the external methods of the listener.
  */
-public class ListenerActions {
+public final class ListenerActions {
+
+    private ListenerActions() {}
 
     public static Object externInit(BObject clientObject, BString serverUri, BString clientId,
                                     BMap<BString, Object> listenerConfiguration) {

diff --git a/native/src/main/java/io/ballerina/stdlib/mqtt/utils/ModuleUtils.java b/native/src/main/java/io/ballerina/stdlib/mqtt/utils/ModuleUtils.java
@@ -24,7 +24,7 @@
 /**
  * Class holding module related utility functions.
  */
-public class ModuleUtils {
+public final class ModuleUtils {
 
     private static Module mqttModule = null;
 

diff --git a/native/src/main/java/io/ballerina/stdlib/mqtt/utils/MqttConstants.java b/native/src/main/java/io/ballerina/stdlib/mqtt/utils/MqttConstants.java
@@ -24,7 +24,9 @@
 /**
  * Contains the constant values related in the runtime.
  */
-public class MqttConstants {
+public final class MqttConstants {
+
+    private MqttConstants() {}
 
     public static final BString CONNECTION_CONFIGURATION = StringUtils.fromString("connectionConfig");
     public static final BString USERNAME = StringUtils.fromString("username");

diff --git a/native/src/main/java/io/ballerina/stdlib/mqtt/utils/MqttUtils.java b/native/src/main/java/io/ballerina/stdlib/mqtt/utils/MqttUtils.java
@@ -85,7 +85,9 @@
 /**
  * Class containing the utility functions related to the clients.
  */
-public class MqttUtils {
+public final class MqttUtils {
+
+    private MqttUtils() {}
 
     public static BMap<BString, Object> getBMqttMessage(MqttMessage message, String topic) {
         BMap<BString, Object> bMessage = ValueCreator.createRecordValue(ModuleUtils.getModule(),