Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spotbugs failures in java 17 migration #10

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

dilanSachi
Copy link
Contributor

Purpose

$subject

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@dilanSachi dilanSachi changed the base branch from main to java_17_migration August 14, 2023 05:58
@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Aug 14, 2023
@dilanSachi dilanSachi marked this pull request as ready for review August 14, 2023 05:58
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 78.96% and project coverage change: -2.52% ⚠️

Comparison is base (5af1a74) 84.80% compared to head (565edc7) 82.28%.
Report is 17 commits behind head on java_17_migration.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             java_17_migration      #10      +/-   ##
=======================================================
- Coverage                84.80%   82.28%   -2.52%     
- Complexity                  60      139      +79     
=======================================================
  Files                       14       24      +10     
  Lines                      408      717     +309     
  Branches                    62      126      +64     
=======================================================
+ Hits                       346      590     +244     
- Misses                      54       82      +28     
- Partials                     8       45      +37     
Files Changed Coverage Δ
...rina/stdlib/mqtt/compiler/MqttDiagnosticCodes.java 0.00% <0.00%> (ø)
.../stdlib/mqtt/compiler/MqttServiceAnalysisTask.java 50.00% <50.00%> (ø)
...io/ballerina/stdlib/mqtt/compiler/PluginUtils.java 68.00% <68.00%> (ø)
.../compiler/MqttCodeTemplateWithCallerParameter.java 79.41% <79.41%> (ø)
...mpiler/MqttCodeTemplateWithoutCallerParameter.java 79.41% <79.41%> (ø)
...na/stdlib/mqtt/compiler/MqttFunctionValidator.java 80.80% <80.80%> (ø)
...ina/stdlib/mqtt/compiler/MqttServiceValidator.java 93.33% <93.33%> (ø)
...erina/stdlib/mqtt/compiler/MqttCompilerPlugin.java 100.00% <100.00%> (ø)
...rina/stdlib/mqtt/compiler/MqttServiceAnalyzer.java 100.00% <100.00%> (ø)
...allerina/stdlib/mqtt/compiler/PluginConstants.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilanSachi dilanSachi merged commit 3889b95 into java_17_migration Aug 14, 2023
4 of 7 checks passed
@dilanSachi dilanSachi deleted the java_17_migration_fix branch August 14, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip GraalVM Check This will skip the GraalVM compatibility check
Projects
None yet
2 participants