Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of SQL database calls inside transaction contexts #719

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Improve performance of SQL database calls inside transaction contexts #719

merged 3 commits into from
Jun 18, 2024

Conversation

warunalakshitha
Copy link
Contributor

Purpose

$Subject

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

daneshk
daneshk previously approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha
Copy link
Contributor Author

All mysql tests are passing with this change.

@warunalakshitha warunalakshitha changed the base branch from master to trx_fix June 18, 2024 12:42
@warunalakshitha warunalakshitha merged commit 008086d into ballerina-platform:trx_fix Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daneshk daneshk daneshk left review comments

@niveathika niveathika Awaiting requested review from niveathika

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@warunalakshitha @daneshk