Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix File Content Data-Binding Issue #306

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

AzeemMuzammil
Copy link
Member

Purpose

Fixes: ballerina-platform/ballerina-library#6456

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@AzeemMuzammil AzeemMuzammil force-pushed the Azeem-fix-file-content-payload-binding branch from 2845b8a to 2ef303d Compare April 29, 2024 08:47
Copy link
Member

@ayeshLK ayeshLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have to add this to the sanitations.md, since we are changing the original open-api spec ? @NipunaRanasinghe WDYT ?

@AzeemMuzammil
Copy link
Member Author

Don't we have to add this to the sanitations.md, since we are changing the original open-api spec ? @NipunaRanasinghe WDYT ?

Actually he change is already in the sanitations.md:

  • Update the response schema #/components/schemas/content-tree for the endpoint /repos/{owner}/{repo}/contents/{path} to represent the response as an array. This adjustment is made to address a data binding issue.

@AzeemMuzammil AzeemMuzammil merged commit c8fa265 into master Apr 29, 2024
1 check passed
@ayeshLK
Copy link
Member

ayeshLK commented Apr 29, 2024

Actually he change is already in the sanitations.md:

Bit confused. Why have we not done it already then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants