Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csv parsing logic #346

Merged
merged 7 commits into from
May 29, 2024
Merged

Fix csv parsing logic #346

merged 7 commits into from
May 29, 2024

Conversation

aashikam
Copy link
Contributor

@aashikam aashikam commented May 22, 2024

Copy link
Member

@MaryamZi MaryamZi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix seems to be working as expected with the data I'm testing with.

ballerina/Dependencies.toml Show resolved Hide resolved
ballerina/utils.bal Outdated Show resolved Hide resolved
ballerina/utils.bal Outdated Show resolved Hide resolved
@aashikam aashikam marked this pull request as ready for review May 27, 2024 06:17
@aashikam aashikam force-pushed the csverror branch 3 times, most recently from 94114fb to 1867493 Compare May 27, 2024 15:07
ballerina/utils.bal Outdated Show resolved Hide resolved
ballerina/utils.bal Outdated Show resolved Hide resolved
ballerina/build.gradle Show resolved Hide resolved
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NipunaRanasinghe NipunaRanasinghe merged commit 9786f34 into master May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants