Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4.x] Add support for multi-line parameter descriptions #1268

Merged

Conversation

aneeshafedo
Copy link
Contributor

@aneeshafedo aneeshafedo commented Mar 28, 2023

Purpose

$subject
Resolves ballerina-platform/ballerina-library#5294

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Security checks

Test environment

Java JDK 11

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (a65a498) 78.54% compared to head (dff3789) 78.57%.

Additional details and impacted files
@@             Coverage Diff              @@
##              1.4.x    ballerina-platform/openapi-tools#1268      +/-   ##
============================================
+ Coverage     78.54%   78.57%   +0.03%     
- Complexity     1540     1543       +3     
============================================
  Files           120      120              
  Lines          9234     9247      +13     
  Branches       1498     1500       +2     
============================================
+ Hits           7253     7266      +13     
  Misses         1436     1436              
  Partials        545      545              
Impacted Files Coverage Δ
.../generators/client/FunctionSignatureGenerator.java 93.10% <100.00%> (ø)
...core/generators/document/DocCommentsGenerator.java 96.05% <100.00%> (+0.81%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Apr 12, 2023
@github-actions
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Apr 15, 2023
@aneeshafedo aneeshafedo force-pushed the 1.4.x-multiline-doc branch 3 times, most recently from 93b6cfe to ffb29b8 Compare May 3, 2023 04:05
@aneeshafedo aneeshafedo force-pushed the 1.4.x-multiline-doc branch 3 times, most recently from 1f31183 to 7d73d84 Compare May 4, 2023 07:49
@aneeshafedo aneeshafedo marked this pull request as ready for review May 8, 2023 03:22
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aneeshafedo aneeshafedo merged commit 4e9d01a into ballerina-platform:1.4.x May 9, 2023
@aneeshafedo aneeshafedo changed the title Add support for multi-line parameter descriptions [1.4.x] Add support for multi-line parameter descriptions May 15, 2023
aneeshafedo added a commit to aneeshafedo/ballerina-openapi that referenced this pull request May 15, 2023
…#1268)

* Add support for multiline parameter descriptions

* Resolve windows build failure

* Resolve windows build failure

* Add tests
aneeshafedo added a commit to aneeshafedo/ballerina-openapi that referenced this pull request May 15, 2023
…#1268)

* Add support for multiline parameter descriptions

* Resolve windows build failure

* Resolve windows build failure

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants