Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix for providing support for pattern constraint in openapi to ballerina code generation #1340

Merged
merged 14 commits into from
May 18, 2023

Conversation

lnash94
Copy link
Member

@lnash94 lnash94 commented May 2, 2023

Purpose

Fix ballerina-platform/ballerina-library#5290

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.03 🎉

Comparison is base (7872aeb) 78.91% compared to head (db2bc9b) 78.95%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    ballerina-platform/openapi-tools#1340      +/-   ##
============================================
+ Coverage     78.91%   78.95%   +0.03%     
- Complexity     1656     1661       +5     
============================================
  Files           124      124              
  Lines          9690     9716      +26     
  Branches       1569     1573       +4     
============================================
+ Hits           7647     7671      +24     
- Misses         1470     1472       +2     
  Partials        573      573              
Impacted Files Coverage Δ
...java/io/ballerina/openapi/core/GeneratorUtils.java 88.16% <50.00%> (+0.02%) ⬆️
...api/core/generators/schema/TypeGeneratorUtils.java 90.27% <81.81%> (-0.46%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ina-openapi into pattern_1.6.0

# Conflicts:
#	openapi-cli/src/test/java/io/ballerina/openapi/generators/schema/ConstraintTests.java
#	openapi-cli/src/test/resources/testng.xml
@lnash94 lnash94 marked this pull request as ready for review May 9, 2023 06:57
@lnash94 lnash94 changed the title [WIP][Master] Fix for providing support for pattern constraint in openapi to ballerina code generation [master] Fix for providing support for pattern constraint in openapi to ballerina code generation May 9, 2023
@lnash94 lnash94 requested a review from aneeshafedo May 9, 2023 07:06
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnash94 lnash94 merged commit cd6aa0b into ballerina-platform:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants