Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enums in OpenAPI to Ballerina service generation #1346

Merged
merged 2 commits into from
May 18, 2023

Conversation

aneeshafedo
Copy link
Contributor

Purpose

$subject
Resolves ballerina-platform/ballerina-library#5266

Goals

Enum Generation in parameters in service generation

  • Query parameter
  • Header parameter
  • Path parameter

Security checks

Test environment

JAVA JDK 11

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 84.00% and project coverage change: -0.02 ⚠️

Comparison is base (11dcedb) 78.94% compared to head (f115751) 78.93%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    ballerina-platform/openapi-tools#1346      +/-   ##
============================================
- Coverage     78.94%   78.93%   -0.02%     
- Complexity     1659     1663       +4     
============================================
  Files           124      124              
  Lines          9704     9711       +7     
  Branches       1571     1576       +5     
============================================
+ Hits           7661     7665       +4     
  Misses         1470     1470              
- Partials        573      576       +3     
Impacted Files Coverage Δ
...i/core/generators/service/ParametersGenerator.java 84.83% <84.00%> (-0.82%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lnash94 lnash94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@NipunaRanasinghe NipunaRanasinghe merged commit eddef69 into ballerina-platform:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants