Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues found in RC testing #1693

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Fix minor issues found in RC testing #1693

merged 6 commits into from
Apr 24, 2024

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Apr 22, 2024

Purpose

$Subject

  • Add a property to skip publishing client native artifacts to WSO2 nexus. With this change, we have to enable this in the gradle.properties file, if we want to publish the artifacts with release workflow. If we do not need to release we need to mark it as true
  • Fix optional response header mapping in the status code response. Without this change, when we have non-required headers in status code response, it is map to map<string|string[]>. With this change, the optional headers will be mapped as nilable record fields
  • Fix printing Responses with 204 status code cannot have a body warning for response which does not define a request body schema
  • Removed unused OAS_COMMON_102 from the common diagnostics
  • Print the client warning/error diagnostics when bal commands are executed with openAPI tool integration

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lnash94 lnash94 merged commit c1e20e7 into master Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants