Skip to content

Commit

Permalink
Chiadikaobixo chiadikaobi/fix/shared eslint prettier (#326)
Browse files Browse the repository at this point in the history
* refactor: made all packages to use shared eslint/prettier config

fix #224

* fix: made the prettier plugin to come last

fix #232
  • Loading branch information
Chiadikaobixo committed May 17, 2023
1 parent a8f24e4 commit da4aea0
Show file tree
Hide file tree
Showing 10 changed files with 30 additions and 88 deletions.
16 changes: 16 additions & 0 deletions apps/backoffice/.eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
const config = require('../../packages/config/eslintrc.base.cjs');

module.exports = {
...config,
extends: ['react-app', 'react-app/jest', ...config.extends],
env: {
...config.env,
node: true,
},
parserOptions: {
...config.parserOptions,
// These types of configs should be relative to the package's root
tsconfigRootDir: __dirname,
project: ['./tsconfig.eslint.json'],
},
};
1 change: 1 addition & 0 deletions apps/backoffice/.prettierrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = require('../../packages/config/prettierrc.base.cjs');
18 changes: 1 addition & 17 deletions packages/rules-engine/eslintrc.base.cjs
Original file line number Diff line number Diff line change
@@ -1,17 +1 @@
module.exports = {
parser: '@typescript-eslint/parser',
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'prettier',
],
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module',
},
env: {
es6: true,
},
plugins: ['@typescript-eslint'],
};
module.exports = require('../../packages/config/eslintrc.base.cjs');
7 changes: 1 addition & 6 deletions packages/rules-engine/prettierrc.base.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
module.exports = {
semi: true,
trailingComma: 'all',
singleQuote: true,
arrowParens: 'avoid',
};
module.exports = require('../../packages/config/prettierrc.base.cjs');
7 changes: 1 addition & 6 deletions packages/workflow-core/.prettierrc.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
module.exports = {
semi: true,
trailingComma: 'all',
singleQuote: true,
arrowParens: 'avoid',
};
module.exports = require('../../packages/config/prettierrc.base.cjs');
18 changes: 1 addition & 17 deletions packages/workflow-core/eslintrc.base.cjs
Original file line number Diff line number Diff line change
@@ -1,17 +1 @@
module.exports = {
parser: '@typescript-eslint/parser',
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'prettier',
],
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module',
},
env: {
es6: true,
},
plugins: ['@typescript-eslint'],
};
module.exports = require('../../packages/config/eslintrc.base.cjs');
18 changes: 1 addition & 17 deletions sdks/workflow-node-sdk/eslintrc.base.cjs
Original file line number Diff line number Diff line change
@@ -1,17 +1 @@
module.exports = {
parser: '@typescript-eslint/parser',
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'prettier',
],
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module',
},
env: {
es6: true,
},
plugins: ['@typescript-eslint'],
};
module.exports = require('../../packages/config/eslintrc.base.cjs');
7 changes: 1 addition & 6 deletions sdks/workflow-node-sdk/prettierrc.base.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
module.exports = {
semi: true,
trailingComma: 'all',
singleQuote: true,
arrowParens: 'avoid',
};
module.exports = require('../../packages/config/prettierrc.base.cjs');
19 changes: 6 additions & 13 deletions services/workflows-service/.eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,21 +1,15 @@
const config = require('../../packages/config/eslintrc.base.cjs');

module.exports = {
parser: '@typescript-eslint/parser',
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'plugin:import/recommended',
'plugin:import/typescript',
'prettier',
],
...config,
extends: ['plugin:import/recommended', 'plugin:import/typescript', ...config.extends],
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module',
...config.parserOptions,
tsconfigRootDir: __dirname,
project: './tsconfig.json',
},
env: {
es6: true,
...config.env,
node: true,
},
settings: {
Expand All @@ -30,7 +24,6 @@ module.exports = {
node: true,
},
},
plugins: ['@typescript-eslint'],
rules: {
'import/no-cycle': 'error',
'@typescript-eslint/no-unsafe-member-access': 'off',
Expand Down
7 changes: 1 addition & 6 deletions services/workflows-service/.prettierrc.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
module.exports = {
semi: true,
trailingComma: 'all',
singleQuote: true,
arrowParens: 'avoid',
};
module.exports = require('../../packages/config/prettierrc.base.cjs');

0 comments on commit da4aea0

Please sign in to comment.