Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: made all packages to use shared eslint/prettier config #232

Closed
wants to merge 2 commits into from
Closed

refactor: made all packages to use shared eslint/prettier config #232

wants to merge 2 commits into from

Conversation

Chiadikaobixo
Copy link
Contributor

fix #224

Description

Elaborate on the subject, motivation, and context.

Related issues

  • Provide a link to each related issue.

Breaking changes

  • Describe the breaking changes that this pull request introduces.

How these changes were tested

  • Describe the tests that you ran to verify your changes, including devices, operating systems, browsers and versions.

Examples and references

  • Links, screenshots, and other resources related to this change.

Checklist

  • [] I have read the contribution guidelines of this project
  • [] I have read the style guidelines of this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings and errors
  • [] New and existing tests pass locally with my changes

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ae268e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alonp99 alonp99 requested a review from Omri-Levy April 29, 2023 13:43
Omri-Levy
Omri-Levy reviewed May 1, 2023
View reviewed changes
apps/backoffice/.eslintrc.cjs Outdated Show resolved Hide resolved
services/workflows-service/.eslintrc.cjs Outdated Show resolved Hide resolved
@alonp99
Copy link
Collaborator

alonp99 commented May 17, 2023

Thanks @Chiadikaobixo , this looks good

Can you resolve the conflicts so I can merge this?

@alonp99 alonp99 closed this May 17, 2023
@alonp99 alonp99 reopened this May 17, 2023
@alonp99
Copy link
Collaborator

alonp99 commented May 17, 2023

Thanks @Chiadikaobixo , this looks good

Can you resolve the conflicts so I can merge this?

Chiadikaobixo added a commit to Chiadikaobixo/ballerine that referenced this pull request May 17, 2023
@Chiadikaobixo
fix: fixed shared eslint prettier
86d8138 
fix ballerine-io#232
@alonp99 alonp99 closed this in da4aea0 May 17, 2023
@Chiadikaobixo Chiadikaobixo deleted the chiadikaobi/fix/shared-eslint-prettier branch June 28, 2023 11:28
MihirMandviwala pushed a commit that referenced this pull request Feb 12, 2024
@Chiadikaobixo
Chiadikaobixo chiadikaobi/fix/shared eslint prettier (#326)
a13b38e 
* refactor: made all packages to use shared eslint/prettier config

fix #224

* fix: made the prettier plugin to come last

fix #232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonp99 alonp99 alonp99 approved these changes

@Omri-Levy Omri-Levy Awaiting requested review from Omri-Levy

Assignees

@Chiadikaobixo Chiadikaobixo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make all packages use shared eslint/prettier config
3 participants
@Chiadikaobixo @alonp99 @Omri-Levy