Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: made all packages to use shared eslint/prettier config #232

Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions apps/backoffice/.eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,21 +1,14 @@
const config = require('../../packages/config/eslintrc.base.cjs');

module.exports = {
parser: '@typescript-eslint/parser',
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'prettier',
'react-app',
'react-app/jest',
],
...config,
extends: [...config.extends, 'react-app', 'react-app/jest'],
alonp99 marked this conversation as resolved.
Show resolved Hide resolved
env: {
es6: true,
...config.env,
node: true,
},
plugins: ['@typescript-eslint'],
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module',
...config.parserOptions,
// These types of configs should be relative to the package's root
tsconfigRootDir: __dirname,
project: ['./tsconfig.eslint.json'],
Expand Down
8 changes: 1 addition & 7 deletions apps/backoffice/.prettierrc.cjs
Original file line number Diff line number Diff line change
@@ -1,7 +1 @@
module.exports = {
semi: true,
trailingComma: 'all',
singleQuote: true,
arrowParens: 'avoid',
// singleAttributePerLine: true,
};
module.exports = require('../../packages/config/prettierrc.base.cjs');
18 changes: 1 addition & 17 deletions packages/rules-engine/eslintrc.base.cjs
Original file line number Diff line number Diff line change
@@ -1,17 +1 @@
module.exports = {
parser: '@typescript-eslint/parser',
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'prettier',
],
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module',
},
env: {
es6: true,
},
plugins: ['@typescript-eslint'],
};
module.exports = require('../../packages/config/eslintrc.base.cjs');
7 changes: 1 addition & 6 deletions packages/rules-engine/prettierrc.base.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
module.exports = {
semi: true,
trailingComma: 'all',
singleQuote: true,
arrowParens: 'avoid',
};
module.exports = require('../../packages/config/prettierrc.base.cjs');
7 changes: 1 addition & 6 deletions packages/workflow-core/.prettierrc.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
module.exports = {
semi: true,
trailingComma: 'all',
singleQuote: true,
arrowParens: 'avoid',
};
module.exports = require('../../packages/config/prettierrc.base.cjs');
18 changes: 1 addition & 17 deletions sdks/workflow-node-sdk/eslintrc.base.cjs
Original file line number Diff line number Diff line change
@@ -1,17 +1 @@
module.exports = {
parser: '@typescript-eslint/parser',
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'prettier',
],
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module',
},
env: {
es6: true,
},
plugins: ['@typescript-eslint'],
};
module.exports = require('../../packages/config/eslintrc.base.cjs');
7 changes: 1 addition & 6 deletions sdks/workflow-node-sdk/prettierrc.base.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
module.exports = {
semi: true,
trailingComma: 'all',
singleQuote: true,
arrowParens: 'avoid',
};
module.exports = require('../../packages/config/prettierrc.base.cjs');
19 changes: 6 additions & 13 deletions services/workflows-service/.eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,21 +1,15 @@
const config = require('../../packages/config/eslintrc.base.cjs');

module.exports = {
parser: '@typescript-eslint/parser',
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'plugin:import/recommended',
'plugin:import/typescript',
'prettier',
],
...config,
extends: [...config.extends, 'plugin:import/recommended', 'plugin:import/typescript'],
alonp99 marked this conversation as resolved.
Show resolved Hide resolved
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module',
...config.parserOptions,
tsconfigRootDir: __dirname,
project: './tsconfig.json',
},
env: {
es6: true,
...config.env,
node: true,
},
settings: {
Expand All @@ -30,7 +24,6 @@ module.exports = {
node: true,
},
},
plugins: ['@typescript-eslint'],
rules: {
'import/no-cycle': 'error',
'@typescript-eslint/no-unsafe-member-access': 'off',
Expand Down
7 changes: 1 addition & 6 deletions services/workflows-service/.prettierrc.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
module.exports = {
semi: true,
trailingComma: 'all',
singleQuote: true,
arrowParens: 'avoid',
};
module.exports = require('../../packages/config/prettierrc.base.cjs');