Navigation refactor desktop improvements #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esktop-improvements
…esktop-improvements
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…954) * 📝 docs(): improve cdn documentation (#942) * chore(): improve cdn documentation * chore(): format * Create PR for #953 * fix(bal-tabs): render button in nav if no href * fix(bal-tabs): use div instead of nav * fix(bal-tabs): add aria attributes * fix(bal-tabs): background color fix * fix(bal-tabs): format * fix(bal-tabs): adjust line height * fix(bal-tabs): unset border * fix(bal-tabs): add aria hidden and rename id * fix(bal-tabs): remove color attr from button * fix/(bal-tabs): format --------- Co-authored-by: Mladen Planinicic <mladenplaninicic@gmail.com> Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com> Co-authored-by: Gina Biondo <gina.biondo@aperto.com> Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>
hirsch88
added a commit
that referenced
this pull request
Sep 28, 2023
* Create PR for #784 * ♻️ refactor(navigation): meta bar (#931) * Create PR for #907 * chore(): add from to the import of markers and styles in maps documen… (#932) chore(): add from to the import of markers and styles in maps documentation * chore(): update base images * feat: add new component bal-meta-bar * chore(): update base images * chore: change timeout * chore(): update base images * test: adjust visual tests * test: adjust visual tests 2 * test: adjust visual tests 3 * test: adjust visual tests 4 * chore: adjust test * chore(): update base images * chore: trigger build --------- Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com> Co-authored-by: Mladen Planinicic <mladenplaninicic@gmail.com> Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch> * ♻️ refactor(navigation): popover (#921) * Create PR for #908 * feat(popup): add new component * chore: format files * test(popup): add visual test * chore: adjust visual ci * chore: add test selectors * chore: improve popover variant * chore: format files * chore: is able to use 100% of width * chore: adjust visual * chore(): update base images * chore: trigger build * chore(): update base images * chore(): update base images * chore: trigger build * feat(popup): trigger can define variant * feat(popup): trigger can define placement * chore: format files --------- Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com> Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch> * ♻️ refactor(navigation): link (#919) * Create PR for #903 * feat(nav-link): add new component * chore(): format * chore: implement PR feedback * chore: format files * chore(): update base images * chore: trigger build --------- Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com> Co-authored-by: mladenplaninicic <mladenplaninicic@gmail.com> Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch> Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com> * ♻️ refactor(navigation): main + flyout (#935) * Create PR for #906 * chore: update lock file * chore: update tags * chore: update tags * feat: add new component bal-nav-menu-bar * chore: add shadow * fix: transform when scroll * feat: add component flyout * chore: add flyout border when active * chore(): update base images * chore(): update base images * chore: trigger build * chore(): update base images * chore: trigger build --------- Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com> Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch> * Create PR for #911 * chore: update * Z-index (#951) * 📝 docs(): improve cdn documentation (#942) * chore(): improve cdn documentation * chore(): format * feat: Create z-index design tokens and adjust the components. --------- Co-authored-by: Mladen Planinicic <mladenplaninicic@gmail.com> * chore: update z-index * Navigation link grid (#941) * chore(): add grid components * feat(bal-nav): add new components bal-nav-link-grid, bal-nav-link-grid-col and bal-nav-link-group * chore(): refactor * chore(): update base images * chore: remove console logs * chore: merge branch 'refactor/issue-911' into navigation-link-grid --------- Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com> Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch> * chore: add desktop links * chore: add link list * chore: add aria attributes * chore: add active path * chore: support one meta link option * chore: add logo links * chore: create docs * Navigation refactor desktop improvements (#963) * chore(): improve focus * chore(): add overview link * chore(): add overview link * chore(): format --------- Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch> * docs: create story * chore: adjust spacing and overview link * chore: fix z-index and popup with * chore: did popup alignment * chore: adjust z-index * chore: active popup and close menu * chore: render opt * chore: add click event for link items * Navigation refactor desktop improvements (#966) * chore(): improve focus * chore(): add overview link * chore(): add overview link * chore(): format * chore(): disable body scroll when flyout is scrollable * chore(): remove containerSize prop * chore(): fix line width * chore(): fix duplicated mobile list * chore(): open meta and menu if they are active * chore(): add underline offset for links * chore(): format * ♻️ refactor(navigation): use buttons for a tab when there is no href (#954) * 📝 docs(): improve cdn documentation (#942) * chore(): improve cdn documentation * chore(): format * Create PR for #953 * fix(bal-tabs): render button in nav if no href * fix(bal-tabs): use div instead of nav * fix(bal-tabs): add aria attributes * fix(bal-tabs): background color fix * fix(bal-tabs): format * fix(bal-tabs): adjust line height * fix(bal-tabs): unset border * fix(bal-tabs): add aria hidden and rename id * fix(bal-tabs): remove color attr from button * fix/(bal-tabs): format --------- Co-authored-by: Mladen Planinicic <mladenplaninicic@gmail.com> Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com> Co-authored-by: Gina Biondo <gina.biondo@aperto.com> Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch> * chore(): don't animate tabs line if tab target is blank --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com> Co-authored-by: Gina Biondo <gina.biondo@aperto.com> Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch> * chore: remove console logs * chore: fix meta bar pos * fix(nav): disable scroll with popups * fix(nav): chevron and mobile title link is not active * fix(nav): keep flyout open when changing meta * fix(nav): adjust animation glitches * chore: focus first element of popup * fix: backdrop click * chore: fix app height ios issue * chore: fix react and angular build * chore(): improve example (#970) * chore(): fix navigation line (#968) * chore: improve a11y * chore: update props * docs: popup * test: update visual test for popup * test: update visual test for popup * test: update visual test for popup * test: update visual test for popup * chore(): update base images * test: update visual test for popup * test: update popup tests * chore(): update base images * test: update popup tests * test: update popup tests * chore(): update base images * test: update popup tests * chore(): update base images * chore: trigger build * test: improve visual * test: improve visual * test: improve visual * chore: trigger build * chore: fix lint issues * chore(): add visual tests (#973) * chore(): add visual tests * chore(): update base images * chore(): trigger build --------- Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com> * chore: merge branch 'main' into refactor/issue-911 * chore: build file * chore: format files * fix(pagination): adjust disabled look of small controls * Nav docs (#989) * chore(): add documentation * chore(): add documentation * chore(): add documentation * chore(): format * chore(): add documentation * chore: remove unused files * chore: format files * chore: adjust hint min width * fix: typings * chore(): update base images * chore: format files * chore(): update base images * chore(): improve docs * chore(): improve docs * chore: add controls back * chore(): update base images * chore: trigger build * chore: add google console * chore: trigger build * chore: add data prop to be more flexible like for data tracking * fix(bal-nav): make main tabs icon rotates, improve scrolling on mobile * chore: Merge branch 'main' into refactor/issue-911 * chore: create menu with native elements * chore: update mobile view * chore: fix component tests * chore: fix build * chore: fix popup tests * chore: fix list height * chore(): update base images * chore: trigger build * chore: remove unused package * chore(): add overview link to the example * chore: fix line-height and long texts * fix:(accordion): adjust min-heights * chore: scroll to selected link item * chore: format files * chore: add link option for accordion button * chore: adjust large button height * chore: adjust border colors in visual test * chore: waitAfterIdleCallback before taking screenshot * chore: adjust changesets * chore(): update base images * chore: trigger build * chore: adjust visual tests * chore(): update base images * chore: trigger build * chore: adjust visual test * chore(): update base images * chore: trigger build * chore: update visual test * chore: adjust visual test --------- Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com> Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mladen Planinicic <mladenplaninicic@gmail.com> Co-authored-by: mladenplaninicic <mladenplaninicic@users.noreply.github.com> Co-authored-by: Gina Biondo <gina.biondo@aperto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
{{short description}}
Acceptance Criteria