Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CHIST-3146): review with Michael #1

Merged
merged 3 commits into from
Oct 20, 2021
Merged

feat(CHIST-3146): review with Michael #1

merged 3 commits into from
Oct 20, 2021

Conversation

dweber019
Copy link
Collaborator

@dweber019 dweber019 commented Oct 19, 2021 •
edited
Loading

  • Spell check
  • README updates
  • Remove baloise.ch.baloise.ch
  • Example for target namespace role binding
  • Code review refactorings

@dweber019 dweber019 self-assigned this Oct 19, 2021
@StephanSST StephanSST self-requested a review October 19, 2021 15:23
schlijo
schlijo approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@schlijo schlijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, good starting point for use on os 3.11.

@dweber019
Copy link
Collaborator Author

Last few commits will improve error handling an logging

@dweber019 dweber019 merged commit 8be5b55 into main Oct 20, 2021
@baopso
Copy link

baopso commented Oct 20, 2021

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dweber019 dweber019 deleted the feat/CHIST-3146 branch October 22, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlijo schlijo schlijo approved these changes

@mbobzin mbobzin mbobzin approved these changes

@StephanSST StephanSST Awaiting requested review from StephanSST

Assignees

@dweber019 dweber019

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dweber019 @baopso @schlijo @mbobzin