Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dot in numbers + copy value #10

Closed
neohazuki opened this issue Dec 4, 2022 · 2 comments · Fixed by #15
Closed

Feature: Dot in numbers + copy value #10

neohazuki opened this issue Dec 4, 2022 · 2 comments · Fixed by #15
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@neohazuki
Copy link

Is possible in next version create dot in CR (money) and copy icon to export.
Is most simple to see the value and make calcs

@Balvald Balvald self-assigned this Dec 6, 2022
@Balvald Balvald added this to the v0.1.3 milestone Dec 6, 2022
@Balvald
Copy link
Owner

Balvald commented Dec 6, 2022

As I understood:

  • Reformat the unsold value shown to have thousand seperators for readability (1,000,000 instead of 1000000)
  • A button to copy value to clipboard. I'm assuming without the unit and thousands seperators. (with the plugin showing: "1,000,000 Cr." it'll put "1000000" onto the clipboard)

I'd make a case for not including the thousand seperators for the copy to clipboard button. (though its ambiguos to me if you've asked for this.)

And thats because of different languages that use different number formats and some do not automatically get converted by either google spreadsheets/LibreOffice Calc which depends on which languages basic number format it considers standard. (probably changeable through its respective settings but who the hell goes there for that?)

TL;DR: priorising either 1.000.000,00 or 1,000,000.00 is a pain for people that encounter their non-standard number format and there are a lot of number formats: https://en.wikipedia.org/wiki/Decimal_separator#Examples_of_use

@neohazuki sounds good, anything to add?

@Balvald Balvald added the enhancement New feature or request label Dec 6, 2022
Balvald added a commit that referenced this issue Dec 6, 2022
These changes concern #10
- Unsold Scan value now has thousand seperators.
- Added a button that copies the raw value of the unsold scan value to the clipboard.
@Balvald
Copy link
Owner

Balvald commented Dec 9, 2022

currently working on all dev branches. will be closed once the 2-clonal-colony-range branch gets merged into dev.

Balvald added a commit that referenced this issue Dec 14, 2022
Concerning #10 :  Was missing a function call that removes the thousands seperators and adds them in again when computing the new value.

Concerning #9 : Was missing a few instances where files (namely notsoldbiodata.json) were not readable after being modified: was missing trunctate()
Balvald added a commit that referenced this issue Dec 14, 2022
These changes concern #10
- Unsold Scan value now has thousand seperators.
- Added a button that copies the raw value of the unsold scan value to the clipboard.
Balvald added a commit that referenced this issue Dec 14, 2022
Concerning #10 :  Was missing a function call that removes the thousands seperators and adds them in again when computing the new value.

Concerning #9 : Was missing a few instances where files (namely notsoldbiodata.json) were not readable after being modified: was missing trunctate()
@Balvald Balvald closed this as completed Dec 14, 2022
@Balvald Balvald linked a pull request Dec 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants