Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Multi Commander support. #9

Closed
Balvald opened this issue Dec 1, 2022 · 6 comments · Fixed by #15
Closed

Feature: Multi Commander support. #9

Balvald opened this issue Dec 1, 2022 · 6 comments · Fixed by #15
Assignees
@Balvald
Labels
enhancement New feature or request
Milestone
v0.2.0

Comments

@Balvald
Copy link
Owner

Balvald commented Dec 1, 2022

plugin needs to know which cmdr is the one that acutally scanned the exobiology.
@Balvald Balvald added the enhancement New feature or request label Dec 1, 2022
@Balvald Balvald self-assigned this Dec 1, 2022
@Balvald Balvald added this to the v0.1.3 milestone Dec 4, 2022
@Balvald
Copy link
Owner Author

Balvald commented Dec 5, 2022 •
edited
Loading

should be up and working. for a fresh install on current dev branch.

Still got to implement to implement renaming the file to something else when not of the current format.

unless it just overwrites it, then that should work. the user can scan their journals, their whole journal limpet collection (probably more exhaustive of all the players discoveries)/game journals at their will.

@Balvald
Copy link
Owner Author

Balvald commented Dec 9, 2022

Have to test #2 with regards to this. Still got uncommited changes for a version of #2 feature that has multicommander support in mind.

@Balvald
Copy link
Owner Author

Balvald commented Dec 11, 2022

I think its should work now. but better gonna test it for a few times.

@Balvald
Copy link
Owner Author

Balvald commented Dec 12, 2022

We already have a break of compatability between the biodata tracking because of this one. Might aswell rework it in another issue

@Balvald Balvald mentioned this issue Dec 12, 2022
Closed
@Balvald
Copy link
Owner Author

Balvald commented Dec 12, 2022

notsoldbiodata tracking does not work as of now. Check if it was just a single Keyerror I missed to catch.

@Balvald
Copy link
Owner Author

Balvald commented Dec 12, 2022 •
edited
Loading

Good thing though the modified journalcrawler works perfectly fine here.

Balvald added a commit that referenced this issue Dec 14, 2022
@Balvald
various fixes
c92c301 
Concerning #10 :  Was missing a function call that removes the thousands seperators and adds them in again when computing the new value.

Concerning #9 : Was missing a few instances where files (namely notsoldbiodata.json) were not readable after being modified: was missing trunctate()
@Balvald Balvald mentioned this issue Dec 14, 2022
Merged
Balvald added a commit that referenced this issue Dec 14, 2022
@Balvald
various fixes
a3527e7 
Concerning #10 :  Was missing a function call that removes the thousands seperators and adds them in again when computing the new value.

Concerning #9 : Was missing a few instances where files (namely notsoldbiodata.json) were not readable after being modified: was missing trunctate()
@Balvald Balvald closed this as completed Dec 14, 2022
@Balvald Balvald linked a pull request Dec 15, 2022 that will close this issue
Pulling new features onto dev #15
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Balvald Balvald

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
1 participant
@Balvald