Pulling new features onto dev #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes concern #10 - Unsold Scan value now has thousand seperators. - Added a button that copies the raw value of the unsold scan value to the clipboard.
Changes: - Added test label and options of the CCR feature that currently can show lat, long heading and the planets radius if its close enough. - fixed isort import order - added type annotations
shows CCR for last scan and the current distance to the last scans. still needs to integrate multicommander support for this feature. fix for notyetsolddata not tracking correctly due to forgetting to give it the cmdr string.
multicommander support integration for CCR
bearing value in degrees is supposed to point directly away from the scan location. Need to test if it currently does so. Added functions that need to be implement to make the ui code less cluttered.
fix for entries being saved for cmdr "" and "null"
No more updating of any information in legacy mode. nicer format for current pos new prices: concerns #12 need to check amphora plant and bark mounds to be completely sure.
ignoring CCR001 too high complexity
put the clipboard function next to the reset function, both are used for doing things with buttons. grouped the code outside the plugin class into regions
Had typos in the key to check if the game is in legacy mode. Fixed that the bearing was shown as mapped to a different interval (because Frontier implemented it this way for the status.json) while on foot compared to being in a vehicle.
Now its always removing the last comma and white space of the scanned/sold systems. Old version had an oversight with planets like Bridge 1 showing: "1, " instead of the correct "1" because the string was not long enough.
This was
linked to
issues
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished and tested: #2, #9 , #10 , #12