Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Update Readme for v0.2.7 #52

Closed
5 tasks done
Balvald opened this issue May 4, 2023 · 3 comments · Fixed by #54
Closed
5 tasks done

[Documentation] Update Readme for v0.2.7 #52

Balvald opened this issue May 4, 2023 · 3 comments · Fixed by #54
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@Balvald
Copy link
Owner

Balvald commented May 4, 2023

Update Readme for v0.2.7

Should reflect changes made of #36
and any other changes/features that I might have missed before.

@Balvald Balvald added the documentation Improvements or additions to documentation label May 4, 2023
@Balvald Balvald added this to the v0.2.7 milestone May 4, 2023
@Balvald Balvald self-assigned this May 4, 2023
@Balvald
Copy link
Owner Author

Balvald commented May 18, 2023

Plugin as it is on dev branch does not handle the second finished exobio scan properly. specifically it does not add the second one to the notyetsoldbiodata.json. It is specifically not a "plugin has forgot to draw itself again"-issue

Journal crawler button does fix it though.

@Balvald
Copy link
Owner Author

Balvald commented May 18, 2023

Plugin as it is on dev branch does not handle the second finished exobio scan properly. specifically it does not add the second one to the notyetsoldbiodata.json. It is specifically not a "plugin has forgot to draw itself again"-issue

Journal crawler button does fix it though.

Opened #53 for this bug in current dev build

@Balvald
Copy link
Owner Author

Balvald commented May 19, 2023

#53 is fixed. Did not shallow copy the reference I'm testing against so it always was the same after the first scan worked fine.

@Balvald Balvald linked a pull request May 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant