unix: Fix "Open in BambuStudio" button on MakerWorld #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the "Open in BambuStudio" button on MakerWorld works by informing the system that BambuStudio is the application to handle URLs with the bambustudio scheme, and that it can handle URLs, not just local files. This fixes this error message visible in Firefox' console when clicking the button on the website: Prevented navigation to “bambustudio://open?file=https%3A%2F%2Fmakerworld.bblmw.com[...]bambu_scraper_grip_ams.3mf” due to an unknown protocol.
bam-winterfell
approved these changes
Jan 10, 2024
|
hi@hadess |
lanewei120
pushed a commit
that referenced
this pull request
Jan 17, 2024
Make the "Open in BambuStudio" button on MakerWorld works by informing the system that BambuStudio is the application to handle URLs with the bambustudio scheme, and that it can handle URLs, not just local files. This fixes this error message visible in Firefox' console when clicking the button on the website: Prevented navigation to “bambustudio://open?file=https%3A%2F%2Fmakerworld.bblmw.com[...]bambu_scraper_grip_ams.3mf” due to an unknown protocol. github pull request: #3314 Change-Id: I3838554ef813767e043c56e406dfb2a862e128c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the "Open in BambuStudio" button on MakerWorld works by informing the system that BambuStudio is the application to handle URLs with the bambustudio scheme, and that it can handle URLs, not just local files.
This fixes this error message visible in Firefox' console when clicking the button on the website: