This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
Dynamically determine package location #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adibas03
changed the title
|
@yleflour |
yleflour
reviewed
Feb 28, 2020
| return join(process.cwd(), filePath); | ||
| } | ||
|
|
||
| function getPackageFileName(platform: string): string { |
There was a problem hiding this comment.
should split into a getAndroidPackageFileName and getIosPackageFileName
There was a problem hiding this comment.
Just a small challenge, PR is too useful for this to prevent merging
There was a problem hiding this comment.
@yleflour Sorry, just seeing this. Been in the cave.
Do I need to do anything on this, or can it be ignored till future updates?
yleflour
approved these changes
Feb 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13
closes #18
closes #22
closes #24