Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

fix 25% => 50% withdrawal bug #1486

Merged
merged 10 commits into from
May 25, 2021
Merged

fix 25% => 50% withdrawal bug #1486

merged 10 commits into from
May 25, 2021

Conversation

Velua
Copy link
Contributor

@Velua Velua commented May 16, 2021

No description provided.

@Velua Velua linked an issue May 16, 2021 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented May 16, 2021

Visit the preview URL for this PR (updated for commit cb1176c):

https://bancor-v2-beta--pr1486-bug-badformat-nxhm54gb.web.app

(expires Mon, 31 May 2021 17:12:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Velua Velua changed the title change getter fix 25% => 50% withdrawal bug May 17, 2021
@ashachaf
Copy link
Collaborator

testing:
100% -> trigger 50% transaction
25% -> trigger 50% transaction
50% -> trigger 25% transaction

@pingustar
Copy link
Collaborator

testing:
100% -> trigger 50% transaction
25% -> trigger 50% transaction
50% -> trigger 25% transaction

I figured out what was causing it and fixed it. We locked it the default decimal amount of 50% and then showed the prompt to change the amount which then had no effect because the default amount was already locked in. It is fixed now and I tested it on the preview link, looks good to me. @ashachaf can you confirm that it is working as intended now?

@Velua can you polish this off by triggering the WETH balance to update once the withdraw is confirmed. Currently the site seems to needs a refresh to show the updated WETH balance.

@Velua
Copy link
Contributor Author

Velua commented May 24, 2021

@Velua can you polish this off by triggering the WETH balance to update once the withdraw is confirmed. Currently the site seems to needs a refresh to show the updated WETH balance.

Just pushed in cb1176c

Good work! @pingustar

@pingustar pingustar merged commit 3b6cb95 into master May 25, 2021
@pingustar pingustar deleted the bug/badFormat branch May 25, 2021 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wETH->ETH flow errors
3 participants